Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add support for Python 3.11 #159

Merged
merged 3 commits into from
Apr 11, 2024
Merged

build: add support for Python 3.11 #159

merged 3 commits into from
Apr 11, 2024

Conversation

mariajgrimaldi
Copy link
Member

@mariajgrimaldi mariajgrimaldi commented Apr 11, 2024 •
edited
Loading

For the details, check the issue openedx/public-engineering#233

@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner April 11, 2024 12:55
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 11, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mariajgrimaldi mariajgrimaldi linked an issue Apr 11, 2024 that may be closed by this pull request
Test openedx-filters on Python 3.11 #153
Closed
6 tasks
felipemontoya
felipemontoya requested changes Apr 11, 2024
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upgrade in itself looks good. The constraint for backports.zoneinfo looks reasonable.

This removes the PII check I left a note worth reviewing before I leave my approval.

requirements/base.txt
# via django
backports-zoneinfo==0.2.1 ; python_version < "3.9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the solution discussed during the maintainers call, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: https://openedx.atlassian.net/wiki/spaces/COMM/pages/4160847886/2024-04-11+Meeting+notes

.github/workflows/ci.yml Show resolved Hide resolved
tox.ini Show resolved Hide resolved
felipemontoya
felipemontoya approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@felipemontoya felipemontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that my questions have been resolved I leave my approval as well

@mariajgrimaldi mariajgrimaldi merged commit e770492 into main Apr 11, 2024
9 checks passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/support-python3.11 branch April 11, 2024 22:24
@openedx-webhooks
Copy link

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@mariajgrimaldi mariajgrimaldi mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ian2012 Ian2012 Ian2012 approved these changes

@felipemontoya felipemontoya felipemontoya approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test openedx-filters on Python 3.11
4 participants
@mariajgrimaldi @openedx-webhooks @felipemontoya @Ian2012