Skip to content

Commit

Permalink
fix: fixup previous commit
Browse files Browse the repository at this point in the history
  • Loading branch information
OmarIthawi committed Mar 26, 2024
1 parent c8d7ee0 commit 95811aa
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ pull_translations:
make clean_translations_temp_directory


extract_translations:
combine_translations:
make clean_translations_temp_directory
python scripts/merge_translation_files.py
python scripts/combine_translations_files.py


validate_translation_files:
Expand Down
3 changes: 0 additions & 3 deletions docs/0002-atlas-translations-management.rst
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@ while Engineers need to have clean architecture with strings split into each app
Combining the files during ``combine_translations``
---------------------------------------------------

Android and iOS apps already extracts the ``.strings`` files therefore there's no need
for a dedicated ``extract_translations`` step.

However, combining the string files to aid Translator Experience in the following manner:

Suppose we have two apps with one string source file in each::
Expand Down

0 comments on commit 95811aa

Please sign in to comment.