Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update some fields in customer agreemnet model #721

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

jajjibhai008
Copy link
Contributor

@jajjibhai008 jajjibhai008 commented Oct 14, 2024

Description

I have made the following updates in the UserAgreement Model

  • Add a net-new field called, Modal Header Text
  • Changed Expired Subscription Modal Messaging to an HTML field, rather than text (Why: So we can emphasize bolding or different color text in the body of the modal)
    • Added sanitization on the field to make it secure by using a bleach package
  • Added a new field Button Label in Modal
  • Added a new field URL for Button in Modal
  • Update the serializer to expose the newly added fields
Screenshot 2024-10-18 at 4 03 17 PM Screenshot 2024-10-18 at 4 06 08 PM

JIRA Ticket - > ENT-9615

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@jajjibhai008 jajjibhai008 force-pushed the eahmadjaved/ENT-9615 branch 5 times, most recently from 9daae1d to 1a568a5 Compare October 16, 2024 11:42
@jajjibhai008 jajjibhai008 merged commit 16c5f53 into master Oct 21, 2024
5 checks passed
@jajjibhai008 jajjibhai008 deleted the eahmadjaved/ENT-9615 branch October 21, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants