Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 423 status in api yaml file #716

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Added 423 status in api yaml file #716

merged 3 commits into from
Oct 7, 2024

Conversation

MueezKhan246
Copy link
Contributor

Description:
added 423 status in api yaml file

JIRA:
https://2u-internal.atlassian.net/jira/software/c/projects/ENT/issues/ENT-9502

@MueezKhan246 MueezKhan246 force-pushed the MueezKhan/Adding-423-Status-For-Licenses-Assign-Endpoint branch from 057e03d to 20e9fd1 Compare September 30, 2024 08:14
sameeramin
sameeramin reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@sameeramin sameeramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we supposed to edit api-compact.yaml file and then decompact it to api.yaml file? Or was it intentional?

sameenfatima78
sameenfatima78 reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to add these changes to both files api-compact.yaml, and api.yaml

@MueezKhan246
Copy link
Contributor Author

Aren't we supposed to edit api-compact.yaml file and then decompact it to api.yaml file? Or was it intentional?

@sameeramin i directly updated api yaml now i have updated compact file thanks for pointing out.

@MueezKhan246
Copy link
Contributor Author

We'll need to add these changes to both files api-compact.yaml, and api.yaml
@sameenfatima78
i have updated compact file now

sameenfatima78
sameenfatima78 reviewed Sep 30, 2024
View reviewed changes
api-compact.yaml Outdated Show resolved Hide resolved
sameeramin
sameeramin approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@sameeramin sameeramin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@MueezKhan246 MueezKhan246 force-pushed the MueezKhan/Adding-423-Status-For-Licenses-Assign-Endpoint branch from af8625f to ae79fc7 Compare October 7, 2024 10:15
@MueezKhan246 MueezKhan246 merged commit ef94bee into master Oct 7, 2024
5 checks passed
@MueezKhan246 MueezKhan246 deleted the MueezKhan/Adding-423-Status-For-Licenses-Assign-Endpoint branch October 7, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameenfatima78 sameenfatima78 sameenfatima78 approved these changes

@sameeramin sameeramin sameeramin approved these changes

@hamzawaleed01 hamzawaleed01 Awaiting requested review from hamzawaleed01

@zamanafzal zamanafzal Awaiting requested review from zamanafzal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MueezKhan246 @sameeramin @sameenfatima78