Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add created time to subscriptions api response #697

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

katrinan029
Copy link
Contributor

Description

include created time in subscriptions api response api/v1/subscriptions/

Link to the associated ticket: https://2u-internal.atlassian.net/browse/ENT-9374

Testing considerations

  1. Follow the set up steps here https://github.com/openedx/license-manager to get the server running
  2. checkout this branch with git fetch -a and git checkout knguyen2/ent-9374
  3. visit http://localhost:18170/login and get the customer uuid from any subscription plan http://localhost:18170/admin/subscriptions/subscriptionplan/. create a plan if one doesn't exist
  4. copy the customer uuid and paste in the following link: https://license-manager-internal.stage.edx.org/api/v1/subscriptions/?enterprise_customer_uuid=<CUSTOMER_UUID>
  5. verify that you see the created date
    Screenshot 2024-08-19 at 11 32 38 AM
  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

Copy link

@pmakwana93 pmakwana93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@katrinan029 katrinan029 merged commit 678a0a9 into master Aug 19, 2024
5 checks passed
@katrinan029 katrinan029 deleted the knguyen2/ent-9374 branch August 19, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants