Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: desired number of sub plan licenses. #572

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

iloveagent57
Copy link
Contributor

  • Sets a longer timelimit on provision_licenses_task()
  • Fixes bug where saving an existing plan overwrites desired number of license back to 0.

Fixing this bug allows us to "top up" the licenses in a plan to the desired number by simply saving the plan again.

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

* Sets a longer timelimit on `provision_licenses_task()`
* Fixes bug where saving an existing plan overwrites desired number of license back to 0.
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems reasonable.

@iloveagent57 iloveagent57 merged commit 8c7063d into master Jan 26, 2024
7 checks passed
@iloveagent57 iloveagent57 deleted the aed/license-prov-time-limit branch January 26, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants