Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make subscription license provisioning asynchronous and batched #566

Merged
merged 1 commit into from
Jan 25, 2024
Merged

feat: make subscription license provisioning asynchronous and batched #566

merged 1 commit into from
Jan 25, 2024

Conversation

pwnage101
Copy link
Contributor

ENT-8269

Description

Description of changes made

Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-XXXX

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@pwnage101 pwnage101 force-pushed the pwnage101/ENT-8269 branch 3 times, most recently from dd366a0 to 821546c Compare January 24, 2024 03:47
@pwnage101 pwnage101 changed the title feat: make subscription license provisioning eventually consistent feat: make subscription license provisioning asynchronous and batched Jan 24, 2024
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-8269 branch 4 times, most recently from 61b9cee to 6218060 Compare January 24, 2024 04:36
@pwnage101 pwnage101 marked this pull request as ready for review January 24, 2024 04:36
@pwnage101 pwnage101 force-pushed the pwnage101/ENT-8269 branch 3 times, most recently from 316c286 to 4cbfebd Compare January 25, 2024 01:34
iloveagent57
iloveagent57 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@iloveagent57 iloveagent57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one main testing nit.

license_manager/apps/subscriptions/tasks.py Outdated Show resolved Hide resolved
license_manager/apps/subscriptions/tests/test_tasks.py Show resolved Hide resolved
@pwnage101 pwnage101 merged commit cbdf611 into master Jan 25, 2024
5 checks passed
@pwnage101 pwnage101 deleted the pwnage101/ENT-8269 branch January 25, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iloveagent57 iloveagent57 iloveagent57 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pwnage101 @iloveagent57