Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed bulk_license_enrollment parameter name #556

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

zamanafzal
Copy link
Member

Description

Description of changes made

Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-XXXX

Testing considerations

  • Include instructions for any required manual tests, and any manual testing that has
    already been performed.
  • Include unit and a11y tests as appropriate
  • Consider performance issues.
  • Check that Database migrations are backwards-compatible

Post-review

Squash commits into discrete sets of changes

@sameenfatima78
Copy link
Member

@zamanafzal can we make this same change in api.yaml file too? Copythe api-compact content in yamllint and paste it as is in api.yaml. Also, can we check the name of the body parameter for the other endpoint to check if that's unique too?

@sameenfatima78 sameenfatima78 self-requested a review January 10, 2024 13:23
Copy link
Member

@sameenfatima78 sameenfatima78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments

@zamanafzal
Copy link
Member Author

@sameenfatima78 from the other endpoint you mean revoke_licenses endpoint?

@sameenfatima78
Copy link
Member

@sameenfatima78 from the other endpoint you mean revoke_licenses endpoint?

yes. bulk-revoke

@zamanafzal zamanafzal force-pushed the zafzal/fix-bulk-enroll-endpoint-query-param branch from 1560871 to 5bf10e7 Compare January 10, 2024 13:31
@zamanafzal zamanafzal merged commit 227342c into master Jan 10, 2024
7 checks passed
@zamanafzal zamanafzal deleted the zafzal/fix-bulk-enroll-endpoint-query-param branch January 10, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants