Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds a LicenseTransferJob model and admin #535

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

iloveagent57
Copy link
Contributor

@iloveagent57 iloveagent57 commented Oct 19, 2023

Also installs django-autocomplete-light for help to support advanced admin autocomplete field filtering, and therefore runs make upgrade to pull in some other new package versions.

Description

Adds a model for a "job" to transfer licenses from one plan to another within the same customer agreement.

Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-7704

Testing considerations

  1. Create a customer agreement and two plans related to it.
  2. For one of the plans, modify some of the license states to assigned or active. Give them distinct, fake email addresses.
  3. Create a LicenseTransferJob: http://localhost:18170/admin/subscriptions/licensetransferjob/ Optionally use the is_dry_run option to see which licenses would be moved, without actually moving them.
  4. After creating the plan, use the admin list view to select your record, then choose the "process" action and click "Go"
    image

If not a dry-run, notice that the licenses have changed subscription plans.

@iloveagent57 iloveagent57 force-pushed the aed/license-transfer branch 2 times, most recently from 4a85528 to 25c78c4 Compare October 23, 2023 15:51
@iloveagent57 iloveagent57 force-pushed the aed/license-transfer branch 8 times, most recently from d24deaf to f3b9611 Compare October 24, 2023 14:26
Copy link
Contributor

@pwnage101 pwnage101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one nit, otherwise looks great!

Also installs django-autocomplete-light for help to support
advanced admin autocomplete field filtering, and therefore
runs make upgrade to pull in some other new package versions.
@iloveagent57 iloveagent57 merged commit 6d6911c into master Oct 24, 2023
6 checks passed
@iloveagent57 iloveagent57 deleted the aed/license-transfer branch October 24, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants