fix: DB tx isolation and informative license logging #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnagro
approved these changes
Oct 5, 2023
Track license changes in a celery task outside of the DB transaction block that updates the license state, so that task can read the committed updates to the license records. Also add helpful logging to our license assignment/reminder email tasks. ENT-7795
iloveagent57
force-pushed
the
aed/fix-bulk-assignment-tracking
branch
from
d8a3efe to
3790e16
Compare
iloveagent57
force-pushed
the
aed/fix-bulk-assignment-tracking
branch
from
e38222a to
be7edcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Track license changes in a celery task outside of the DB transaction block that updates the license state, so that task can read the committed updates to the license records.
Also add helpful logging to our license assignment/reminder email tasks. ENT-7795
Link to the associated ticket: https://openedx.atlassian.net/browse/ENT-7795
Testing considerations
already been performed.
Post-review
Squash commits into discrete sets of changes