chore: upgrade django simple history package #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UsamaSadiq
commented
Sep 27, 2023
| sed 's/edx-drf-extensions<7.0.0//g' requirements/common_constraints.txt > requirements/common_constraints.tmp | ||
| mv requirements/common_constraints.tmp requirements/common_constraints.txt | ||
| sed 's/drf-jwt<1.19.1//g' requirements/common_constraints.txt > requirements/common_constraints.tmp | ||
| sed 's/django-simple-history==3.0.0//g' requirements/common_constraints.txt > requirements/common_constraints.tmp |
There was a problem hiding this comment.
Override the common constraint to upgrade the package to latest version.
license_manager/apps/subscriptions/migrations/0061_auto_20230927_1110.py
Outdated
Show resolved
Hide resolved
UsamaSadiq
force-pushed
the
upgrade-django-simple-history-package
branch
from
74b64cc to
4832562
Compare
awais786
approved these changes
Sep 27, 2023
UsamaSadiq
commented
Sep 27, 2023
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('subscriptions', '0060_historicalsubscriptionlicensesource'), |
There was a problem hiding this comment.
new migration created with the latest version of django-simple-history package.
| @@ -435,3 +435,6 @@ | |||
|
|
|||
| # Django Admin Settings | |||
| VALIDATE_FORM_EXTERNAL_FIELDS = True | |||
|
|
|||
| # disable indexing on history_date | |||
| SIMPLE_HISTORY_DATE_INDEX = False | |||
There was a problem hiding this comment.
Added setting to avoid db_index change in migrations due to updated simple-history package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Django-simple-historypackage forDjango 4.2support.django-simple-history==3.4.0.