Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove offset when studio header exists #491

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

khudym
Copy link
Contributor

@khudym khudym commented Jul 3, 2024

Description

  • this PR proposes making the TinyMce toolbar_sticky_offset to 0 when there is "studio-header" on the page

Before

Schedule & details page

Знімок екрана 2023-12-19 о 14 12 40

Course updates page

Знімок екрана 2024-01-02 о 14 20 10

After

Schedule & details page

Screenshot 2024-07-04 at 20 13 12

Course updates page
Screenshot 2024-07-04 at 20 12 07

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 3, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 3, 2024

Thanks for the pull request, @khudym! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (c84e322) to head (ccbe859).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   88.86%   88.92%   +0.05%     
==========================================
  Files         248      248              
  Lines        4534     4540       +6     
  Branches      933      940       +7     
==========================================
+ Hits         4029     4037       +8     
+ Misses        474      470       -4     
- Partials       31       33       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khudym khudym marked this pull request as ready for review July 4, 2024 17:15
@KristinAoki KristinAoki merged commit a22a260 into openedx:main Jul 10, 2024
7 checks passed
@openedx-webhooks
Copy link

@khudym 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants