Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: block resize with long content and broken image path #478

Closed
wants to merge 3 commits into from
Closed

fix: block resize with long content and broken image path #478

wants to merge 3 commits into from

Conversation

ihor-romaniuk
Copy link
Contributor

Description

This pull request contains:

  • styling fixes of Problem content editor for correct displaying with long/wide content with adding block limits and horizontal scroll
  • fix broken images URL in hints and answers blocks

Screenshots before:

image image

Screenshots after:

image image

Steps to Reproduce:

  1. Enable new problem editor and sharing by adding in /admin/waffle/flag/
  1. In studio open unit -> add new component -> Problem -> Single / Multiple select
  2. Add images, table to hints and answers blocks
  3. Check problem displaying

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 29, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented May 29, 2024 •
edited
Loading

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ihor-romaniuk ihor-romaniuk mentioned this pull request May 29, 2024
Open
@GlugovGrGlib GlugovGrGlib requested a review from a team May 30, 2024 12:46
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Jul 30, 2024
KristinAoki
KristinAoki suggested changes Aug 16, 2024
View reviewed changes
src/editors/data/redux/thunkActions/problem.js
if (isBlankProblem({ rawOLX })) {
dispatch(actions.problem.setEnableTypeSelection(camelizeKeys(defaultSettings)));
} else {
dispatch(actions.problem.load(getDataFromOlx({ rawOLX, rawSettings, defaultSettings })));
const dataFromOlx = getDataFromOlx({ rawOLX, rawSettings, defaultSettings });
preprocessProblemData(dataFromOlx, getState());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be happening when the tinyMCE editor loads, so it is not necessary to preprocess the problem here. See https://github.com/openedx/frontend-lib-content-components/blob/main/src/editors/sharedComponents/TinyMceWidget/hooks.js#L74-L97

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is not longer needed, please remove all changes related to preprocessProblemData

src/editors/data/services/cms/utils.js
Comment on lines +36 to +40
export const replaceRelativeImageUrlsByAbsolute = (text, lmsEndpointUrl) => {
const relativeSrcRegExp = /(?<=src=")(\/.*?)(?=")/g;
const replaceRelativeToAbsoluteUrl = (relativeUrl) => `${lmsEndpointUrl}${relativeUrl}`;
return (text || '').replaceAll(relativeSrcRegExp, replaceRelativeToAbsoluteUrl);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment regarding preprocessProblemData and remove if necessary.

@KristinAoki KristinAoki added waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. and removed needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Aug 16, 2024
@KristinAoki
Copy link
Member

Hi! Thank you for your contribution to this repo. This repo is being deprecated and all the code is being moved to frontend-app-course-authoring. If you would like your work to be included in the transition please resolve outstanding requests for this PR. This PR will automatically close once frontend-app-course-authoring PR #1208 is merged.

@bradenmacdonald
Copy link
Contributor

Closing as we've now moved this code, per the notice above. Please re-open this PR against https://github.com/openedx/frontend-app-course-authoring/ if you'd like to continue it.

@openedx-webhooks
Copy link

@ihor-romaniuk Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristinAoki KristinAoki KristinAoki requested changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ihor-romaniuk @openedx-webhooks @KristinAoki @bradenmacdonald @mphilbrick211