fix: remove useEffect that fires before search params

[KristinAoki]

JIRA Ticket: TNL-11505

It was reported an issue regarding videos not populating the Video ID field when uploading a video via the video component. This issue results in the display of an error message stating, “No playable video source found,” due to the absence of the video ID in the designated field. A workaround for this video issue is to manually copy the video ID from the video block and paste it into the Video ID field.

Testing

1. Open a course.
2. Edit to the video component.
3. Click "Replace video"
4. Select the desired video for the unit.
5. The video will upload with the Video ID

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.36%. Comparing base (5069cf8) to head (db52cdf).
Report is 10 commits behind head on main.

Files	Patch %	Lines
...ainers/VideoEditor/components/VideoEditorModal.jsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
- Coverage   89.09%   88.36%   -0.74%     
==========================================
  Files         234      247      +13     
  Lines        4310     4563     +253     
  Branches      889      956      +67     
==========================================
+ Hits         3840     4032     +192     
- Misses        449      503      +54     
- Partials       21       28       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[connorhaugh]

Was this error a regression in functionality? if so, do we want to add a test for it?

[rayzhou-bit]

Small nit on eslint comments. Change looks good to me!

[rayzhou-bit]

Nit:
The rules-of-hooks disable in L15 can be removed.
If returnToGallery is renamed to useReturnToGallery, the other rules-of-hooks disables can be removed as well.

[KristinAoki]

Was this error a regression in functionality? if so, do we want to add a test for it?

This was not an regression in functionality. There bug has been around for a while and was not consistently reproducible. I do not think any additional tests are needed.