Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: displaying the correct default randomization value #413

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

DmytroAlipov
Copy link
Contributor

Description:

No matter what changes we make to the Advanced Settings in the Randomization field, the default value for the Randomization field remains Never on the Editor page.

  • Advanced Settings:
Знімок екрана 2023-10-20 о 10 50 39
  • Editor page:

Before:

Знімок екрана 2023-10-20 о 10 59 19 Знімок екрана 2023-10-20 о 11 00 20

After:

Знімок екрана 2023-10-20 о 11 08 34

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 20, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 20, 2023
@DmytroAlipov DmytroAlipov force-pushed the fix-randomization-field branch from 9b4e26f to 0bde695 Compare October 24, 2023 18:05
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfa4577) 90.49% compared to head (0bde695) 90.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #413   +/-   ##
=======================================
  Coverage   90.49%   90.50%           
=======================================
  Files         228      228           
  Lines        4115     4116    +1     
  Branches      822      823    +1     
=======================================
+ Hits         3724     3725    +1     
  Misses        370      370           
  Partials       21       21           
Files Coverage Δ
...omponents/EditProblemView/SettingsWidget/index.jsx 80.00% <ø> (ø)
...sWidget/settingsComponents/Randomization/index.jsx 100.00% <100.00%> (ø)
src/editors/data/constants/problem.js 100.00% <ø> (ø)
src/editors/data/redux/thunkActions/problem.js 93.02% <100.00%> (ø)
src/editors/data/redux/thunkActions/video.js 91.79% <ø> (ø)
src/editors/data/services/cms/types.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 24, 2023
@mphilbrick211 mphilbrick211 requested a review from a team October 24, 2023 18:53
@mphilbrick211
Copy link

Hi @openedx/teaching-and-learning! This is ready for review :)

@KristinAoki KristinAoki merged commit 60439d5 into openedx:main Nov 30, 2023
5 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov DmytroAlipov deleted the fix-randomization-field branch December 1, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants