Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: master to alpha #451

Merged
merged 61 commits into from
Mar 19, 2024
Merged
Show file tree
Hide file tree
Changes from 54 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
a847fa9
fix(deps): update dependency @svgr/webpack to v8.1.0 (#443)
renovate[bot] Sep 25, 2023
0009871
chore(deps): update dependency @types/react to v17.0.65
renovate[bot] Sep 25, 2023
a3185e5
fix(deps): update dependency autoprefixer to v10.4.16
renovate[bot] Sep 25, 2023
437f763
fix(deps): update dependency postcss to v8.4.30
renovate[bot] Sep 25, 2023
aad2bfa
fix(deps): update dependency postcss-custom-media to v10.0.1
renovate[bot] Sep 25, 2023
1cfeff4
fix(deps): update dependency postcss-rtlcss to v4.0.8
renovate[bot] Sep 25, 2023
b4b57c8
fix(deps): update dependency sharp to v0.32.6
renovate[bot] Sep 26, 2023
982bbb7
fix(deps): update dependency webpack-bundle-analyzer to v4.9.1
renovate[bot] Sep 26, 2023
ac5d346
feat!: babel-plugin-react-intl to babel-plugin-formatjs migration (#313)
abdullahwaheed Sep 28, 2023
4ab5421
chore(deps): update react monorepo
renovate[bot] Sep 28, 2023
a89ed0f
refactor: add @openedx in renovate automate configuration (#461)
Mashal-m Oct 2, 2023
1ec7a93
fix: upgraded postcss to fix vulnerability (#465)
abdullahwaheed Oct 6, 2023
4510b22
chore(deps): update dependency @types/react to v17.0.68
renovate[bot] Oct 18, 2023
ff5c4bb
fix(deps): update dependency postcss-custom-media to v10.0.2
renovate[bot] Oct 18, 2023
05c4fba
build(deps): bump @babel/traverse from 7.22.20 to 7.23.2 (#468)
dependabot[bot] Oct 18, 2023
d5941ad
fix(deps): update formatjs monorepo
renovate[bot] Oct 18, 2023
5889cd5
chore(deps): update dependency @types/react to v17.0.69
renovate[bot] Oct 18, 2023
9c7ba96
refactor: updated README file to reflect template changes (#464)
Mashal-m Oct 24, 2023
3c4ed9a
fix: Exclude openedx scoped packages.
feanil Oct 30, 2023
918d049
Merge pull request #475 from openedx/feanil/exclude_openedx
Nov 1, 2023
337170b
fix(deps): update dependency webpack to v5.89.0 (#472)
renovate[bot] Nov 8, 2023
5b7aeff
fix(deps): update dependency sass to v1.69.5 (#446)
renovate[bot] Nov 16, 2023
0b50243
chore(deps): update react monorepo
renovate[bot] Nov 16, 2023
19abbec
fix(deps): update dependency postcss-rtlcss to v4.0.9
renovate[bot] Nov 16, 2023
cf5c12e
fix(deps): update formatjs monorepo
renovate[bot] Nov 16, 2023
0d131cd
fix(deps): update dependency webpack-bundle-analyzer to v4.10.1 (#479)
renovate[bot] Dec 6, 2023
11b5ac2
chore(deps): update actions/checkout action to v4 (#463)
renovate[bot] Dec 6, 2023
c34ab56
chore(deps): update react monorepo
renovate[bot] Dec 6, 2023
638ac46
fix(deps): update dependency postcss to v8.4.32
renovate[bot] Dec 6, 2023
a5f7377
fix(deps): update dependency sharp to v0.33.0 (#483)
renovate[bot] Dec 8, 2023
fb68ea1
chore(deps): update dependency typescript to v5.3.3 (#482)
renovate[bot] Dec 8, 2023
5ce301c
fix(deps): update dependency html-webpack-plugin to v5.5.4
renovate[bot] Dec 8, 2023
6cc1ef3
docs: Move from restructureText to Markdown
feanil Dec 14, 2023
6247de3
fix: Add a warning prior to the package move.
feanil Dec 14, 2023
ef95f32
Merge pull request #487 from openedx/feanil/pre-scope-move
Dec 15, 2023
c738672
fix: Correct some copy-pasta.
feanil Dec 15, 2023
676fc8f
Merge pull request #489 from openedx/feanil/fix_copy_pasta
Dec 15, 2023
ca40183
fix: Make updates to deploy to the openedx scope.
feanil Dec 14, 2023
d6868bc
Merge pull request #488 from openedx/feanil/scope-move
Dec 15, 2023
6b1211f
fix: Update some scripts and docs.
feanil Dec 15, 2023
7542996
Merge pull request #490 from openedx/feanil/docs_and_script_fixes
Dec 15, 2023
7303e90
chore(deps): update actions/setup-node action to v4 (#486)
renovate[bot] Dec 20, 2023
2534d2b
chore(deps): update dependency @types/react to v17.0.73
renovate[bot] Dec 20, 2023
99f41d2
fix(deps): update dependency cssnano to v6.0.2
renovate[bot] Dec 20, 2023
6a9ea62
fix(deps): update dependency sharp to v0.33.1
renovate[bot] Dec 20, 2023
c746034
fix: fixed jest config to ignore @opendedx namespaced packages (#495)
abdullahwaheed Dec 27, 2023
cb0f994
fix(deps): update dependency html-webpack-plugin to v5.6.0 (#494)
renovate[bot] Jan 8, 2024
c36c97d
fix(deps): update dependency webpack-merge to v5.10.0 (#485)
renovate[bot] Jan 8, 2024
d0dba48
chore(deps): update dependency @types/react to v17.0.74
renovate[bot] Jan 8, 2024
b1f52a3
fix(deps): update dependency cssnano to v6.0.3
renovate[bot] Jan 8, 2024
c66332a
fix(deps): update dependency postcss to v8.4.33
renovate[bot] Jan 8, 2024
50fb91c
fix(deps): update dependency postcss-loader to v7.3.4
renovate[bot] Jan 8, 2024
04871cb
fix(deps): update dependency sass to v1.69.7
renovate[bot] Jan 8, 2024
fd0aac6
fix(deps): update dependency sass-loader to v13.3.3
renovate[bot] Jan 8, 2024
571a89f
fix(deps): update dependency source-map-loader to v4.0.2
renovate[bot] Jan 8, 2024
0b7b0e5
build(deps): bump follow-redirects from 1.15.2 to 1.15.4 (#506)
dependabot[bot] Jan 11, 2024
0c40722
fix(deps): update dependency postcss-rtlcss to v5 (#504)
renovate[bot] Jan 11, 2024
3b0e8f8
fix(deps): update dependency style-loader to v3.3.4
renovate[bot] Jan 11, 2024
5651620
fix(deps): update dependency sharp to v0.33.2
renovate[bot] Jan 12, 2024
873f969
chore(deps): update dependency @types/react to v17.0.75
renovate[bot] Jan 15, 2024
35415fe
fix: reverted sharp to v0.32.6 to fix architcture dependent issues (#…
abdullahwaheed Feb 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
- name: Setup Nodejs
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VER }}
- name: Install dependencies
Expand Down
12 changes: 5 additions & 7 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup Nodejs Env
run: echo "NODE_VER=`cat .nvmrc`" >> $GITHUB_ENV
- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VER }}
node-version-file: '.nvmrc'
- name: Install dependencies
run: npm ci
- name: Lint
Expand All @@ -32,5 +30,5 @@ jobs:
with:
semantic_version: 16
env:
GITHUB_TOKEN: ${{ secrets.SEMANTIC_RELEASE_GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.SEMANTIC_RELEASE_NPM_TOKEN }}
GITHUB_TOKEN: ${{ secrets.OPENEDX_SEMANTIC_RELEASE_GITHUB_TOKEN}}
NPM_TOKEN: ${{ secrets.OPENEDX_SEMANTIC_RELEASE_NPM_TOKEN }}
4 changes: 2 additions & 2 deletions .github/workflows/sync-master-alpha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ jobs:
name: Syncing branches
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Set up Node
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 18
- name: Create Pull Request
Expand Down
295 changes: 295 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,295 @@
# frontend-build

[![Build
Status](https://api.travis-ci.com/edx/frontend-build.svg?branch=master)](https://travis-ci.com/edx/frontend-build)
![npm\_version](https://img.shields.io/npm/v/@openedx/frontend-build.svg)
[![Codecov](https://img.shields.io/codecov/c/github/edx/frontend-build)](https://codecov.io/gh/edx/frontend-build)
[![license](https://img.shields.io/npm/l/@openedx/frontend-build.svg)](https://github.com/edx-unsupported/frontend-base/blob/master/LICENSE)

## Purpose

The purpose of this package is to provide a common sense foundation and
setup for frontend projects including:

- linting (eslint)
- testing (jest)
- development server (webpack-dev-server)
- build (webpack)

This package can serve as a single dev dependency replacing a large
number of dev and build dependencies. It aims to provide common sense
defaults that should be good for most edX projects out of the box, but
can extended or overridden where needed.

## Cloning and Startup

``` {.}
1. Clone your new repo:

``git clone https://github.com/openedx/frontend-build.git``

2. Use node v18.x.

The current version of the micro-frontend build scripts support node 18.
Using other major versions of node *may* work, but this is unsupported. For
convenience, this repository includes an .nvmrc file to help in setting the
correct node version via `nvm <https://github.com/nvm-sh/nvm>`_.

3. Install npm dependencies:

``cd frontend-build && npm ci``
```

## Usage

CLI commands are structured: `fedx-scripts <targetScript> <options>`.
Options are passed on to the target script, so refer to each target
script\'s CLI documentation to learn what options are available. Example
package.json:

{
"scripts": {
"build": "fedx-scripts webpack",
"i18n_extract": "fedx-scripts formatjs extract",
"lint": "fedx-scripts eslint --ext .jsx,.js .",
"precommit": "npm run lint",
"snapshot": "fedx-scripts jest --updateSnapshot",
"start": "fedx-scripts webpack-dev-server --progress",
"test": "fedx-scripts jest --coverage --passWithNoTests",
"serve": "fedx-scripts serve"
},
"dependencies": {
...
},
"devDependencies": {
"@openedx/frontend-build": "1.0.0"
}
}

## Extending or Overriding Config Presets

This package contains a set of configuration presets:

- webpack-prod (or webpack)
- webpack-dev (or webpack-dev-server)
- webpack-dev-stage (for running development apps against stage apis)
- babel
- babel-preserve-modules
- jest
- eslint

If you need to extend or modify a configuration you can add your own
configuration files, either by extending frontend-build\'s configuration
files or supplying your own wholesale.

Method 1: Extend base config (babel.config.js):

const { createConfig } = require('@openedx/frontend-build');
module.exports = createConfig('babel', {
/* option overrides or extensions */
});

Method 2: Custom manipulations (babel.config.js):

const { getBaseConfig } = require('@openedx/frontend-build');
const config = getBaseConfig('babel');

/* Custom config manipulations */

module.exports = config;

Frontend build will look in the following locations for configuration
files in your project.

- eslint: `<project_root>/.eslintrc.js`
- jest: `<project_root>/jest.config.js`
- babel: `<project_root>/babel.config.js`
- webpack-prod: `<project_root>/webpack.prod.config.js`
- webpack-dev-server: `<project_root>/webpack.dev.config.js`

You may specify custom config file locations via the command line if you
prefer a different location. Example package.json:

{
"scripts": {
"build": "fedx-scripts webpack --config ./config/webpack.config.js",
"start:stage": "fedx-scripts webpack-dev-server --config webpack.dev-stage.config.js",
...
}
}

Note, specifying a custom config location for babel may cause issues
with other tools in frontend-build. eslint, jest, webpack, and
webpack-dev-server configuration presets rely upon the babel config and
resolve the location of the config file according to the default
locations described above. If you need to move the babel config file to
a custom location, you may also need to customize references to its
location in other configuration files. Please reach out to the FedX team
if you need to do this and are running into problems.

## Local module configuration for Webpack


The development webpack configuration allows engineers to create a
\"module.config.js\" file containing local module overrides. This means
that if you\'re developing a new feature in a shared library
(\@edx/frontend-platform, \@openedx/paragon, etc.), you can add the local
location of that repository to your module.config.js file and the
webpack build for your application will automatically pick it up and use
it, rather than its node\_modules version of the file.

**NOTE: This module.config.js file should be added to your**
[.gitignore]{.title-ref}.

An example module.config.js file looks like the following. You can copy
this into your application to use local versions of paragon and
frontend-platform:

module.exports = {
/*
Modules you want to use from local source code. Adding a module here means that when this app
runs its build, it'll resolve the source from peer directories of this app.

moduleName: the name you use to import code from the module.
dir: The relative path to the module's source code.
dist: The sub-directory of the source code where it puts its build artifact. Often "dist".
*/
localModules: [
{ moduleName: '@openedx/brand', dir: '../src/brand-openedx' }, // replace with your brand checkout
{ moduleName: '@openedx/paragon/scss/core', dir: '../src/paragon', dist: 'scss/core' },
{ moduleName: '@openedx/paragon/icons', dir: '../src/paragon', dist: 'icons' },
{ moduleName: '@openedx/paragon', dir: '../src/paragon', dist: 'dist' },
{ moduleName: '@edx/frontend-platform', dir: '../src/frontend-platform', dist: 'dist' },
],
};

## Steps

1. Copy the `module.config.js` into your frontend app repository,
modifying it as necessary.
2. Run `npm install && npm run build` within any shared NPM package you
want to use locally.
3. Restart your app.

## Notes

- The \"dir\" and \"dist\" keys give you granular control over the
shape of your repository\'s distribution. Paragon, for instance,
needs two separate entries to pick up both JS and SCSS imports.
- The directory location `../src` (relative to the root of your
frontend app repository) is recommended for shared NPM package
repositories, since it will work whether or not you are running your
frontend via devstack. If you are *not* running your frontend via
devstack, then you can place your shared libraries anywhere in your
file system, updating the \"dir\" key accordingly. To learn more,
see [this devstack ADR on local
packages](https://github.com/openedx/devstack/tree/master/docs/decisions/0005-frontend-package-mounts.rst).
- This mechanism uses Webpack resolve aliases, as documented here:
<https://webpack.js.org/configuration/resolve/#resolvealias>

## Override default .env.development environment variables with .env.private

In some situations, you may want to override development environment
variables defined in .env.development with private environment variables
that should never be checked into a repository. For example, a
.env.development file may contain secrets for a third-party service
(e.g., Algolia) that you\'d like to use during development but want to
ensure these secrets are not checked into Git.

You may create a [.env.private]{.title-ref} with any overrides of the
environment settings configured in [.env.development]{.title-ref}.

**Note: .env.private should be added to your project\'s .gitignore so it
does not get checked in.**

## Serving a production Webpack build locally

In some scenarios, you may want to run a production Webpack build
locally. To serve a production build locally:

1. Create an `env.config.js` file containing the configuration for
local development, with the exception of `NODE_ENV='production'`.
2. Run `npm run build` to build the production assets. The output
assets will rely on the local development configuration specified in
the prior step.
3. Add an NPM script `serve` to your application\'s `package.json`
(i.e., `"serve": "fedx-scripts serve"`).
4. Run `npm run serve` to serve your production build assets. It will
attempt to run the build on the same port specified in the
`env.config.js` file.

## Development

This project leverages the command line interface for webpack, jest,
eslint, and babel. Because of this, local development can be tricky. The
easiest way to do local development on this project is to either run
scripts inside the project in example or to test with an existing
project you can do the following:

1. Delete the node\_modules directories in the host project:
`rm -rf node_modules/`
2. Move frontend-build inside the host project and delete its node
modules folder
`mv ../frontend-build ./ && rm -rf frontend-build/node_modules`
3. Install the development version of frontend-build
`npm i --save-dev @openedx/frontend-build@file:./frontend-build`.

## License

The code in this repository is licensed under the AGPLv3 unless
otherwise noted.

Please see [LICENSE](LICENSE) for details.

## Contributing

Contributions are very welcome. Please read [How To
Contribute](https://openedx.org/r/how-to-contribute) for details.

This project is currently accepting all types of contributions, bug
fixes, security fixes, maintenance work, or new features. However,
please make sure to have a discussion about your new feature idea with
the maintainers prior to beginning development to maximize the chances
of your change being accepted. You can start a conversation by creating
a new issue on this repo summarizing your idea.

## Getting Help

If you\'re having trouble, we have discussion forums at
<https://discuss.openedx.org> where you can connect with others in the
community.

Our real-time conversations are on Slack. You can request a [Slack
invitation](https://openedx.org/slack), then join our [community Slack
workspace](https://openedx.slack.com/). Because this is a frontend
repository, the best place to discuss it would be in the [\#wg-frontend
channel](https://openedx.slack.com/archives/C04BM6YC7A6).

For anything non-trivial, the best path is to open an issue in this
repository with as many details about the issue you are facing as you
can provide.

<https://github.com/openedx/frontend-build/issues>

For more information about these options, see the [Getting
Help](https://openedx.org/community/connect) page.

## Reporting Security Issues

Please do not report security issues in public. Please email
<[email protected]>.

## Optimization

To increase optimization by reducing unused CSS, you can set
`USE_PURGECSS=true` in `.env` or as ENV var in the corresponding MFE.
However, note that doing this will increase build time by 30%. It\'s
thus not recommended to use this option during development. On the other
hand, enabling PurgeCSS will increase browser performance for the end
user by as much as 20% (as measured by
[lighthouse](https://developer.chrome.com/docs/lighthouse/overview/)).
Operators are encouraged to do so for production deployments.

For more information about optimizing MFEs, refer to the [issue
\#138](https://github.com/openedx/wg-frontend/issues/138) in the
wg-frontend repository.
Loading
Loading