refactor: support process.env.PARAGON_THEME_URLS

openedx · Aug 9, 2024 · 516c1bf · 516c1bf
1 parent 182100f
commit 516c1bf
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/lib/plugins/paragon-webpack-plugin/ParagonWebpackPlugin.js b/lib/plugins/paragon-webpack-plugin/ParagonWebpackPlugin.js
@@ -41,23 +41,24 @@ class ParagonWebpackPlugin {
   }
 
   /**
-   * Resolves the MFE configuration for ``PARAGON_THEME_URLS`` in env.config.js
+   * Resolves the MFE configuration for ``PARAGON_THEME_URLS`` in the following priority order:
+   *
+   * 1. ``envConfig.PARAGON_THEME_URLS`` (JS based)
+   * 3. ``process.env.PARAGON_THEME_URLS`` (JSON based)
    *
    * @returns {Object} Metadata about the Paragon and brand theme URLs from configuration.
    */
   async resolveParagonThemeUrlsFromConfig() {
     let envConfig;
-    if (fs.existsSync(envConfigFile)) {
-      try {
+    try {
+      if (fs.existsSync(envConfigFile)) {
         envConfig = require(envConfigFile);
-      } catch (error) {
-        console.info('Paragon Plugin cannot load env.config file, if you want to preload the theme url be sure your file is a CommonJS module');
       }
+      const paragonThemeUrls = envConfig?.PARAGON_THEME_URLS ?? JSON.parse(process.env.PARAGON_THEME_URLS);
+      this.paragonThemeUrlsConfig = paragonThemeUrls;
+    } catch (error) {
+      console.info('Paragon Plugin cannot load PARAGON_THEME_URLS, skipping.');
     }
-
-    const paragonThemeUrls = envConfig?.PARAGON_THEME_URLS ?? {};
-
-    this.paragonThemeUrlsConfig = paragonThemeUrls;
   }
 
   /**