fix: Use browserslist-config #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2024
arbrandes
force-pushed
the
fix-browserslist-config
branch
2 times, most recently
from
c06026a to
365acda
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 1086 1086
Branches 165 166 +1
=========================================
Hits 1086 1086 ☔ View full report in Codecov by Sentry. |
We were installing browserslist-config but not declaring it. This had the effect that webpack - and likely others - were not using it.
Declaring `browserslist` in package.json exposed a bug in the download.js tests that wasn't causing failures before (but arguably, should): one can't use arrow functions to mock constructors because calling `new` on them doesn't work. See the NOTE under: https://jestjs.io/docs/es6-class-mocks#-module-factory-function-must-return-a-function
Remove a file that was previously added by mistake.
arbrandes
force-pushed
the
fix-browserslist-config
branch
from
365acda to
b2cfff5
Compare
brian-smith-tcril
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were installing browserslist-config but not declaring it (as per the documentation and frontend-template-application). This had the effect that webpack - and likely others - were not using it.
For those curious, we discovered this by way of trying to get this to work: overhangio/tutor-indigo#109 (comment).