Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency react-pdf to v7 [security] #1813 #372

Closed

Conversation

milad-emami
Copy link
Contributor

Description

Updates react-pdf to version 7 and improves PDF worker configuration by using CDN delivery.

Changes

  • Update PDF.js worker configuration to use CDN
  • Remove local PDF worker file from public directory
  • Add TextLayer CSS import for better PDF rendering
  • Configure worker source URL to use CDNJS
  • Improve PDF rendering stability and security

Testing Instructions

  1. Navigate to any page with PDF preview functionality
  2. Verify PDF files load and display correctly
  3. Test PDF navigation (next/previous pages)
  4. Verify page number input works
  5. Check PDF rendering in different screen sizes

Related Information

  • Issue: #1813
  • Previous worker configuration used local file
  • New configuration uses CDNJS for better performance and security

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 9, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 9, 2024

Thanks for the pull request, @milad-emami!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @codewithemad. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e39533c) to head (c1de9bc).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #372   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          109       109           
  Lines         1086      1085    -1     
  Branches       165       165           
=========================================
- Hits          1086      1085    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodeWithEmad CodeWithEmad force-pushed the fix/pdf-worker-cdn-config branch from 86e9a63 to b08da63 Compare November 25, 2024 08:25
@milad-emami milad-emami marked this pull request as draft November 25, 2024 10:44
@milad-emami milad-emami force-pushed the fix/pdf-worker-cdn-config branch from b08da63 to c1de9bc Compare November 30, 2024 13:02
@milad-emami milad-emami force-pushed the fix/pdf-worker-cdn-config branch from c1de9bc to e39533c Compare November 30, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants