-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent radio criterion shrinking and improve vertical alignment #370
fix: Prevent radio criterion shrinking and improve vertical alignment #370
Conversation
Thanks for the pull request, @milad-emami! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@milad-emami can you kindly update your branch? |
faf5d20
to
fabc373
Compare
- Add flexShrink: 0 style to prevent radio button compression - Add align-items-center class for better vertical alignment
fabc373
to
fff0b80
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #370 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 1086 1086
Branches 164 165 +1
=========================================
Hits 1086 1086 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
Description
This PR fixes the radio criterion layout issues by preventing the radio buttons from shrinking and improving their vertical alignment.
Changes
flexShrink: 0
style to prevent radio button compression in tight spacesalign-items-center
class for better vertical alignment of radio optionsScreenshots
Before:
After: