Persian language (#246)

* fix: corrected typos explaination -> explanation Critera -> Criteria addtional -> additional arbitary -> arbitrary penging -> pending downladFiles -> downloadFiles isLoadeed -> isLoaded selectror -> selector commnents -> comments stirng -> string isGragrding -> isGrading queu -> queue seleted -> selected feecback -> feedback * feat: Persian language (fa_IR) added * chore: Persian translations added * chore: sort language codes alphabetically * chore: camelCase variable used for translated messages * chore: deprecated styling updated --------- Co-authored-by: Leangseu Kim <[email protected]>
openedx · Sep 11, 2023 · e25a5a9 · e25a5a9
1 parent 358263d
commit e25a5a9
Show file tree

Hide file tree

Showing 38 changed files with 87 additions and 85 deletions.
diff --git a/Makefile b/Makefile
@@ -3,7 +3,7 @@ npm-install-%: ## install specified % npm package
 	git add package.json
 
 transifex_resource = frontend-app-ora-grading
-transifex_langs = "ar,fr,es_419,zh_CN,fr_CA,it_IT,pt_PT,de_DE,uk,ru,hi"
+transifex_langs = "ar,de_DE,es_419,fa_IR,fr,fr_CA,hi,it_IT,pt_PT,uk,ru,zh_CN"
 
 intl_imports = ./node_modules/.bin/intl-imports.js
 transifex_utils = ./node_modules/.bin/transifex-utils.js

diff --git a/documentation/.ci.yml.md b/documentation/.ci.yml.md
@@ -26,4 +26,3 @@ There are only two requirements for a good `make target` name
 What `make validate-no-uncommitted-package-lock-changes` does is `git diff`s for any `package-lock.json` file changes in your project.
 
 This is important because `npm` uses the pinned dependencies in your `package-lock.json` file to build the `node_modules` directory. However, the dependencies defined within the `package.json` file can be modified manually, for example, to become misaligned with the dependencies defined within the `package-lock.json`. So when `npm install` executes, the `package-lock.json` file will be updated to mirror the modified `package.json` changes.
-
diff --git a/src/components/FilePreview/FileCard.scss b/src/components/FilePreview/FileCard.scss
@@ -28,6 +28,6 @@
 
 @include media-breakpoint-down(sm) {
   .file-card-title {
-    width: map-get($container-max-widths, "sm")/2;
+    width: calc(map-get($container-max-widths, "sm")/2);
   }
 }
diff --git a/src/containers/CriterionContainer/CriterionFeedback.test.jsx b/src/containers/CriterionContainer/CriterionFeedback.test.jsx
@@ -163,7 +163,7 @@ describe('Criterion Feedback', () => {
   });
 
   describe('mapStateToProps', () => {
-    const testState = { abitaryState: 'some data' };
+    const testState = { arbitraryState: 'some data' };
     const ownProps = { orderNum: props.orderNum };
     let mapped;
     beforeEach(() => {

diff --git a/src/containers/CriterionContainer/RadioCriterion.test.jsx b/src/containers/CriterionContainer/RadioCriterion.test.jsx
@@ -40,14 +40,14 @@ describe('Radio Criterion Container', () => {
       feedback: 'feedback mock',
       options: [
         {
-          explanation: 'explaination',
+          explanation: 'explanation',
           feedback: 'option feedback',
           label: 'this label',
           name: 'option name',
           points: 1,
         },
         {
-          explanation: 'explaination 2',
+          explanation: 'explanation 2',
           feedback: 'option feedback 2',
           label: 'this label 2',
           name: 'option name 2',
@@ -129,7 +129,7 @@ describe('Radio Criterion Container', () => {
   });
 
   describe('mapStateToProps', () => {
-    const testState = { arbitary: 'some data' };
+    const testState = { arbitrary: 'some data' };
     const ownProps = { orderNum: props.orderNum };
     let mapped;
     beforeEach(() => {

diff --git a/src/containers/CriterionContainer/ReviewCriterion.test.jsx b/src/containers/CriterionContainer/ReviewCriterion.test.jsx
@@ -29,14 +29,14 @@ describe('Review Crition Container', () => {
       feedback: 'feedback mock',
       options: [
         {
-          explanation: 'explaination',
+          explanation: 'explanation',
           feedback: 'option feedback',
           label: 'this label',
           name: 'option name',
           points: 1,
         },
         {
-          explanation: 'explaination 2',
+          explanation: 'explanation 2',
           feedback: 'option feedback 2',
           label: 'this label 2',
           name: 'option name 2',
@@ -78,7 +78,7 @@ describe('Review Crition Container', () => {
   });
 
   describe('mapStateToProps', () => {
-    const testState = { arbitary: 'some data' };
+    const testState = { arbitrary: 'some data' };
     const ownProps = { orderNum: props.orderNum };
     let mapped;
     beforeEach(() => {

diff --git a/src/containers/CriterionContainer/__snapshots__/index.test.jsx.snap b/src/containers/CriterionContainer/__snapshots__/index.test.jsx.snap
@@ -19,7 +19,7 @@ exports[`Criterion Container snapshot is graded and is not grading 1`] = `
           this label
         </strong>
         <br />
-        explaination
+        explanation
       </div>
       <div
         className="help-popover-option"
@@ -29,7 +29,7 @@ exports[`Criterion Container snapshot is graded and is not grading 1`] = `
           this label 2
         </strong>
         <br />
-        explaination 2
+        explanation 2
       </div>
     </InfoPopover>
   </Form.Label>
@@ -67,7 +67,7 @@ exports[`Criterion Container snapshot is ungraded and is grading 1`] = `
           this label
         </strong>
         <br />
-        explaination
+        explanation
       </div>
       <div
         className="help-popover-option"
@@ -77,7 +77,7 @@ exports[`Criterion Container snapshot is ungraded and is grading 1`] = `
           this label 2
         </strong>
         <br />
-        explaination 2
+        explanation 2
       </div>
     </InfoPopover>
   </Form.Label>
@@ -115,7 +115,7 @@ exports[`Criterion Container snapshot is ungraded and is not grading 1`] = `
           this label
         </strong>
         <br />
-        explaination
+        explanation
       </div>
       <div
         className="help-popover-option"
@@ -125,7 +125,7 @@ exports[`Criterion Container snapshot is ungraded and is not grading 1`] = `
           this label 2
         </strong>
         <br />
-        explaination 2
+        explanation 2
       </div>
     </InfoPopover>
   </Form.Label>

diff --git a/src/containers/CriterionContainer/index.test.jsx b/src/containers/CriterionContainer/index.test.jsx
@@ -34,14 +34,14 @@ describe('Criterion Container', () => {
       feedback: 'feedback mock',
       options: [
         {
-          explanation: 'explaination',
+          explanation: 'explanation',
           feedback: 'option feedback',
           label: 'this label',
           name: 'option name',
           points: 2,
         },
         {
-          explanation: 'explaination 2',
+          explanation: 'explanation 2',
           feedback: 'option feedback 2',
           label: 'this label 2',
           name: 'option name 2',
@@ -89,30 +89,30 @@ describe('Criterion Container', () => {
     });
 
     test('is ungraded and is grading (Radio criterion get render)', () => {
-      const rubricCritera = el.find('.rubric-criteria');
-      expect(rubricCritera.children(0).name()).toEqual('RadioCriterion');
+      const rubricCriteria = el.find('.rubric-criteria');
+      expect(rubricCriteria.children(0).name()).toEqual('RadioCriterion');
     });
 
     test('is ungraded and is not grading (Review criterion get render)', () => {
       el.setProps({
         isGrading: false,
       });
-      const rubricCritera = el.find('.rubric-criteria');
-      expect(rubricCritera.children(0).name()).toEqual('ReviewCriterion');
+      const rubricCriteria = el.find('.rubric-criteria');
+      expect(rubricCriteria.children(0).name()).toEqual('ReviewCriterion');
     });
 
     test('is graded and is not grading (Radio criterion get render)', () => {
       el.setProps({
         isGrading: false,
         gradeStatus: gradeStatuses.graded,
       });
-      const rubricCritera = el.find('.rubric-criteria');
-      expect(rubricCritera.children(0).name()).toEqual('RadioCriterion');
+      const rubricCriteria = el.find('.rubric-criteria');
+      expect(rubricCriteria.children(0).name()).toEqual('RadioCriterion');
     });
   });
 
   describe('mapStateToProps', () => {
-    const testState = { abitaryState: 'some data' };
+    const testState = { arbitraryState: 'some data' };
     const ownProps = { orderNum: props.orderNum };
     let mapped;
     beforeEach(() => {

diff --git a/src/containers/CriterionContainer/messages.js b/src/containers/CriterionContainer/messages.js
@@ -14,7 +14,7 @@ const messages = defineMessages({
   optional: {
     id: 'ora-grading.CriterionFeedback.optional',
     defaultMessage: '(Optional)',
-    description: 'addtional label for optional feedback field',
+    description: 'additional label for optional feedback field',
   },
   optionPoints: {
     id: 'ora-grading.RadioCriterion.optionPoints',

diff --git a/src/containers/ListView/SubmissionsTable.jsx b/src/containers/ListView/SubmissionsTable.jsx
@@ -63,8 +63,8 @@ export class SubmissionsTable extends React.Component {
   translate = (...args) => this.props.intl.formatMessage(...args);
 
   handleViewAllResponsesClick = (data) => () => {
-    const getsubmissionUUID = (row) => row.original.submissionUUID;
-    this.props.loadSelectionForReview(data.map(getsubmissionUUID));
+    const getSubmissionUUID = (row) => row.original.submissionUUID;
+    this.props.loadSelectionForReview(data.map(getSubmissionUUID));
   };
 
   render() {

diff --git a/src/containers/ResponseDisplay/__snapshots__/FileDownload.test.jsx.snap b/src/containers/ResponseDisplay/__snapshots__/FileDownload.test.jsx.snap
@@ -43,7 +43,7 @@ exports[`FileDownload component snapshot download is completed 1`] = `
       />,
       "pending": <FormattedMessage
         defaultMessage="Downloading"
-        description="Download files penging state label"
+        description="Download files pending state label"
         id="ora-grading.ResponseDisplay.SubmissionFiles.downloading"
       />,
     }
@@ -96,7 +96,7 @@ exports[`FileDownload component snapshot download is failed 1`] = `
       />,
       "pending": <FormattedMessage
         defaultMessage="Downloading"
-        description="Download files penging state label"
+        description="Download files pending state label"
         id="ora-grading.ResponseDisplay.SubmissionFiles.downloading"
       />,
     }
@@ -149,7 +149,7 @@ exports[`FileDownload component snapshot download is inactive 1`] = `
       />,
       "pending": <FormattedMessage
         defaultMessage="Downloading"
-        description="Download files penging state label"
+        description="Download files pending state label"
         id="ora-grading.ResponseDisplay.SubmissionFiles.downloading"
       />,
     }
@@ -202,7 +202,7 @@ exports[`FileDownload component snapshot download is pending 1`] = `
       />,
       "pending": <FormattedMessage
         defaultMessage="Downloading"
-        description="Download files penging state label"
+        description="Download files pending state label"
         id="ora-grading.ResponseDisplay.SubmissionFiles.downloading"
       />,
     }

diff --git a/src/containers/ResponseDisplay/messages.js b/src/containers/ResponseDisplay/messages.js
@@ -24,7 +24,7 @@ const messages = defineMessages({
   downloading: {
     id: 'ora-grading.ResponseDisplay.SubmissionFiles.downloading',
     defaultMessage: 'Downloading',
-    description: 'Download files penging state label',
+    description: 'Download files pending state label',
   },
   downloaded: {
     id: 'ora-grading.ResponseDisplay.SubmissionFiles.downloaded',

diff --git a/src/containers/ReviewActions/components/SubmissionNavigation.test.jsx b/src/containers/ReviewActions/components/SubmissionNavigation.test.jsx
@@ -19,7 +19,7 @@ jest.mock('data/redux/grading/selectors', () => ({
     doesExist: (state) => ({ nextDoesExist: state }),
   },
   activeIndex: (state) => ({ activeIndex: state }),
-  selectionLength: (state) => ({ selectionlength: state }),
+  selectionLength: (state) => ({ selectionLength: state }),
 }));
 jest.mock('data/redux/requests/selectors', () => ({
   allowNavigation: (state) => ({ allowNavigation: state }),

diff --git a/src/containers/ReviewModal/ReviewContent.test.jsx b/src/containers/ReviewModal/ReviewContent.test.jsx
@@ -53,7 +53,7 @@ describe('ReviewContent component', () => {
     test('isFailed loads from requests.isFailed(fetchSubmission)', () => {
       expect(mapped.isFailed).toEqual(selectors.requests.isFailed(testState, { requestKey }));
     });
-    test('isLoadeed loads from requests.isCompleted(fetchSubmission)', () => {
+    test('isLoaded loads from requests.isCompleted(fetchSubmission)', () => {
       expect(mapped.isLoaded).toEqual(selectors.requests.isCompleted(testState, { requestKey }));
     });
   });

diff --git a/src/containers/ReviewModal/ReviewErrors/DownloadErrors.test.jsx b/src/containers/ReviewModal/ReviewErrors/DownloadErrors.test.jsx
@@ -62,7 +62,7 @@ describe('DownloadErrors component', () => {
     });
     describe('behavior', () => {
       describe('clearState', () => {
-        it('calls props.clearState with requestKey: downladFiles', () => {
+        it('calls props.clearState with requestKey: downloadFiles', () => {
           el.instance().cancelAction();
           expect(props.clearState).toHaveBeenCalledWith({ requestKey: RequestKeys.downloadFiles });
         });

diff --git a/src/containers/ReviewModal/ReviewErrors/SubmitErrors/hooks.test.js b/src/containers/ReviewModal/ReviewErrors/SubmitErrors/hooks.test.js
@@ -106,7 +106,7 @@ describe('Review Modal Submit Error hooks', () => {
       errorStatus = 'test-status';
       const mockErrorProps = (args) => ({
         confirm: { confirm: args },
-        headingMessag: { headingMessage: args },
+        headingMessage: { headingMessage: args },
         contentMessage: { contentMessage: args },
       });
       const mockProps = mockErrorProps({ dispatch, errorStatus });

diff --git a/src/containers/Rubric/RubricFeedback.test.jsx b/src/containers/Rubric/RubricFeedback.test.jsx
@@ -32,7 +32,7 @@ jest.mock('data/redux/grading/selectors', () => ({
     overallFeedback: jest.fn((...args) => ({
       selectedOverallFeedback: args,
     })),
-    isGrading: jest.fn((...args) => ({ isGragrding: args })),
+    isGrading: jest.fn((...args) => ({ isGrading: args })),
   },
   validation: {
     overallFeedbackIsInvalid: jest.fn((...args) => ({
@@ -44,7 +44,7 @@ jest.mock('data/redux/grading/selectors', () => ({
 describe('Rubric Feedback component', () => {
   const props = {
     intl: { formatMessage },
-    config: 'config stirng',
+    config: 'config string',
     isGrading: true,
     value: 'some value',
     isInvalid: false,
@@ -135,7 +135,7 @@ describe('Rubric Feedback component', () => {
   });
 
   describe('mapStateToProps', () => {
-    const testState = { abitaryState: 'some data' };
+    const testState = { arbitraryState: 'some data' };
     let mapped;
     beforeEach(() => {
       mapped = mapStateToProps(testState);

diff --git a/src/containers/Rubric/__snapshots__/RubricFeedback.test.jsx.snap b/src/containers/Rubric/__snapshots__/RubricFeedback.test.jsx.snap
@@ -10,7 +10,7 @@ exports[`Rubric Feedback component snapshot feedback value is invalid 1`] = `
     >
       <FormattedMessage
         defaultMessage="Overall comments"
-        description="Rubric overall commnents label"
+        description="Rubric overall comments label"
         id="ora-grading.Rubric.overallComments"
       />
     </span>
@@ -53,7 +53,7 @@ exports[`Rubric Feedback component snapshot is graded 1`] = `
     >
       <FormattedMessage
         defaultMessage="Overall comments"
-        description="Rubric overall commnents label"
+        description="Rubric overall comments label"
         id="ora-grading.Rubric.overallComments"
       />
     </span>
@@ -84,7 +84,7 @@ exports[`Rubric Feedback component snapshot is grading 1`] = `
     >
       <FormattedMessage
         defaultMessage="Overall comments"
-        description="Rubric overall commnents label"
+        description="Rubric overall comments label"
         id="ora-grading.Rubric.overallComments"
       />
     </span>

diff --git a/src/containers/Rubric/hooks.test.js b/src/containers/Rubric/hooks.test.js
@@ -43,15 +43,15 @@ describe('Rubric hooks', () => {
     afterEach(state.restore);
     describe('redux values', () => {
       beforeEach(() => { hook = hooks.reduxValues(); });
-      test('loads gradeIsPending from isPending requests selectror on submitGrade request', () => {
+      test('loads gradeIsPending from isPending requests selector on submitGrade request', () => {
         expect(hook.gradeIsPending.useSelector(testState)).toEqual(
           selectors.requests.isPending(testState, { requestKey: RequestKeys.submitGrade }),
         );
       });
       test('loads criteriaIndices from rubric selector', () => {
         expect(hook.criteriaIndices).toEqual(useSelector(selectors.app.rubric.criteriaIndices));
       });
-      test('loads isCompleted from requests selectror on submitGrade request', () => {
+      test('loads isCompleted from requests selector on submitGrade request', () => {
         expect(hook.isCompleted.useSelector(testState)).toEqual(
           selectors.requests.isCompleted(testState, { requestKey: RequestKeys.submitGrade }),
         );
@@ -62,7 +62,7 @@ describe('Rubric hooks', () => {
       test('loads isGrading from grading selector for selected submission', () => {
         expect(hook.isGrading).toEqual(useSelector(selectors.grading.selected.isGrading));
       });
-      test('loads lockIsPending from isPending requests selectror on setLock request', () => {
+      test('loads lockIsPending from isPending requests selector on setLock request', () => {
         expect(hook.lockIsPending.useSelector(testState)).toEqual(
           selectors.requests.isPending(testState, { requestKey: RequestKeys.setLock }),
         );

diff --git a/src/containers/Rubric/messages.js b/src/containers/Rubric/messages.js
@@ -24,7 +24,7 @@ const messages = defineMessages({
   overallComments: {
     id: 'ora-grading.Rubric.overallComments',
     defaultMessage: 'Overall comments',
-    description: 'Rubric overall commnents label',
+    description: 'Rubric overall comments label',
   },
   addComments: {
     id: 'ora-grading.Rubric.addComments',
Original file line number	Diff line number	Diff line change
Expand Up		@@ -26,4 +26,3 @@ There are only two requirements for a good `make target` name
		What `make validate-no-uncommitted-package-lock-changes` does is `git diff`s for any `package-lock.json` file changes in your project.

		This is important because `npm` uses the pinned dependencies in your `package-lock.json` file to build the `node_modules` directory. However, the dependencies defined within the `package.json` file can be modified manually, for example, to become misaligned with the dependencies defined within the `package-lock.json`. So when `npm install` executes, the `package-lock.json` file will be updated to mirror the modified `package.json` changes.