feat: remove cta and hide notifications banner if no accounts url

openedx · Aug 20, 2024 · 32e356a · 32e356a
1 parent f433d33
commit 32e356a
Show file tree

Hide file tree

Showing 8 changed files with 3 additions and 100 deletions.
diff --git a/src/App.jsx b/src/App.jsx
@@ -9,7 +9,6 @@ import { LearningHeader as Header } from '@edx/frontend-component-header';
 import { selectors } from 'data/redux';
 
 import DemoWarning from 'containers/DemoWarning';
-import CTA from 'containers/CTA';
 import NotificationsBanner from 'containers/NotificationsBanner';
 import ListView from 'containers/ListView';
 
@@ -27,7 +26,6 @@ export const App = ({ courseMetadata, isEnabled }) => (
         data-testid="header"
       />
       {!isEnabled && <DemoWarning />}
-      <CTA />
       <NotificationsBanner />
       <main data-testid="main">
         <ListView />

diff --git a/src/App.test.jsx b/src/App.test.jsx
@@ -18,7 +18,6 @@ jest.mock('@edx/frontend-component-header', () => ({
 jest.mock('@edx/frontend-component-footer', () => ({ FooterSlot: 'Footer' }));
 
 jest.mock('containers/DemoWarning', () => 'DemoWarning');
-jest.mock('containers/CTA', () => 'CTA');
 jest.mock('containers/ListView', () => 'ListView');
 jest.mock('components/Head', () => 'Head');
 

diff --git a/src/__snapshots__/App.test.jsx.snap b/src/__snapshots__/App.test.jsx.snap
@@ -11,7 +11,6 @@ exports[`App router component snapshot: disabled (show demo warning) 1`] = `
       data-testid="header"
     />
     <DemoWarning />
-    <CTA />
     <NotificationsBanner />
     <main
       data-testid="main"
@@ -33,7 +32,6 @@ exports[`App router component snapshot: enabled 1`] = `
       courseTitle="course-title"
       data-testid="header"
     />
-    <CTA />
     <NotificationsBanner />
     <main
       data-testid="main"

diff --git a/src/containers/CTA/CTA.test.jsx b/src/containers/CTA/CTA.test.jsx
diff --git a/src/containers/CTA/__snapshots__/CTA.test.jsx.snap b/src/containers/CTA/__snapshots__/CTA.test.jsx.snap
diff --git a/src/containers/CTA/index.jsx b/src/containers/CTA/index.jsx
diff --git a/src/containers/CTA/messages.js b/src/containers/CTA/messages.js
diff --git a/src/containers/NotificationsBanner/index.jsx b/src/containers/NotificationsBanner/index.jsx
@@ -1,3 +1,4 @@
+import _ from 'lodash';
 import React from 'react';
 
 import { getConfig } from '@edx/frontend-platform';
@@ -6,7 +7,8 @@ import { PageBanner, Hyperlink } from '@openedx/paragon';
 
 import messages from './messages';
 
-export const NotificationsBanner = () => (
+// eslint-disable-next-line no-confusing-arrow
+export const NotificationsBanner = () => _.isEmpty(getConfig().ACCOUNT_SETTINGS_URL) ? null : (
   <PageBanner variant="accentB">
     <span>
       <FormattedMessage {...messages.infoMessage} />