Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: add test in CourseOutlineTray" and "fix: only one in-course experience sidebar can be open at a time failing" #1547

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

farhaanbukhsh
Copy link
Member

Reverts #1519

Revert "fix: add test in CourseOutlineTray"

This reverts commit 038b05b.

Revert "fix: only one in-course experience sidebar can be open at a time failing"

This reverts commit 020e7fb.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 4, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @farhaanbukhsh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@farhaanbukhsh
Copy link
Member Author

@bradenmacdonald when you are around can you review and merge this revert, pretty please :) 🙏🏾

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.81%. Comparing base (4a925f9) to head (74d6313).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
- Coverage   89.81%   89.81%   -0.01%     
==========================================
  Files         325      325              
  Lines        5589     5587       -2     
  Branches     1348     1348              
==========================================
- Hits         5020     5018       -2     
  Misses        554      554              
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…en..."

(and "fix: add test in CourseOutlineTray")
This reverts commit 020e7fb and 038b05b
@bradenmacdonald bradenmacdonald force-pushed the farhaan/revert-sidebar-open branch from 3df9f8f to 74d6313 Compare December 4, 2024 18:49
Copy link
Contributor

@bradenmacdonald bradenmacdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to rebase this and fix a conflict, but it looks good to me. I'm going to merge shortly. Thanks!

@bradenmacdonald bradenmacdonald merged commit b09bcbd into master Dec 4, 2024
7 checks passed
@bradenmacdonald bradenmacdonald deleted the farhaan/revert-sidebar-open branch December 4, 2024 19:06
@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants