Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add Node 20 to CI matrix #1445

Merged
merged 3 commits into from
Sep 3, 2024

Conversation

BilalQamar95
Copy link
Contributor

Description

As a first step in the upgrade to Node 20, add it to the CI matrix as a non-blocking test.

See the tracking issue for further information.

@BilalQamar95 BilalQamar95 self-assigned this Aug 23, 2024
This was referenced Aug 23, 2024
@@ -341,6 +341,7 @@ class Calculator extends Component {
<li>arccsch(4x+y)</li>
</ul>
</td>
{ /* eslint-disable-next-line jsx-a11y/control-has-associated-label */ }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention why this change is needed.

Copy link
Contributor Author

@BilalQamar95 BilalQamar95 Sep 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error (A control must be associated with a text label) and the corresponding ESLint ignore might seem self-explanatory as the rule jsx-a11y/control-has-associated-label typically applies to interactive controls like buttons, inputs, or other form elements that require labels for accessibility. In this case, <td> is a table cell element, which doesn’t function as an interactive control and therefore doesn’t require a label. The eslint-disable comment was added to prevent unnecessary warnings for this specific use case.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.77%. Comparing base (a681333) to head (3939b5a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1445   +/-   ##
=======================================
  Coverage   87.77%   87.77%           
=======================================
  Files         310      310           
  Lines        5319     5319           
  Branches     1315     1315           
=======================================
  Hits         4669     4669           
  Misses        633      633           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BilalQamar95 BilalQamar95 force-pushed the bilalqamar95/node20-upgrade-1 branch from 3939b5a to 3124beb Compare September 3, 2024 13:22
@brian-smith-tcril brian-smith-tcril merged commit dc1e9cd into master Sep 3, 2024
13 checks passed
@brian-smith-tcril brian-smith-tcril deleted the bilalqamar95/node20-upgrade-1 branch September 3, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants