-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add Node 20 to CI matrix #1445
Conversation
@@ -341,6 +341,7 @@ class Calculator extends Component { | |||
<li>arccsch(4x+y)</li> | |||
</ul> | |||
</td> | |||
{ /* eslint-disable-next-line jsx-a11y/control-has-associated-label */ } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's mention why this change is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error (A control must be associated with a text label)
and the corresponding ESLint ignore might seem self-explanatory as the rule jsx-a11y/control-has-associated-label
typically applies to interactive controls like buttons, inputs, or other form elements that require labels for accessibility. In this case, <td>
is a table cell element, which doesn’t function as an interactive control and therefore doesn’t require a label. The eslint-disable
comment was added to prevent unnecessary warnings for this specific use case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1445 +/- ##
=======================================
Coverage 87.77% 87.77%
=======================================
Files 310 310
Lines 5319 5319
Branches 1315 1315
=======================================
Hits 4669 4669
Misses 633 633
Partials 17 17 ☔ View full report in Codecov by Sentry. |
3939b5a
to
3124beb
Compare
Description
As a first step in the upgrade to Node 20, add it to the CI matrix as a non-blocking test.
See the tracking issue for further information.