Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] fix: make progress graph respect course settings #1313

Conversation

dyudyunov
Copy link
Contributor

@dyudyunov dyudyunov commented Mar 4, 2024

Description

This is a backport from the master branch: #1194

Fix an issue when the Progress Graph toggle change in the studio has no effect on the Learning MFE.

Related backport for the edx-platform: openedx/edx-platform#34324

Please check the original PRs for more details.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 4, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@b24568f). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master    #1313   +/-   ##
=============================================================
  Coverage                              ?   88.05%           
=============================================================
  Files                                 ?      266           
  Lines                                 ?     4519           
  Branches                              ?     1143           
=============================================================
  Hits                                  ?     3979           
  Misses                                ?      526           
  Partials                              ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arbrandes arbrandes changed the title chore: bump frontend-platform (#1209) [Backport] fix: make progress graph respect course settings Mar 4, 2024
@arbrandes arbrandes merged commit 3b409b0 into openedx:open-release/quince.master Mar 4, 2024
6 checks passed
@openedx-webhooks
Copy link

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov dyudyunov deleted the fix-progress-graph-toggling branch March 5, 2024 07:48
@itsjeyd itsjeyd added the backport PR backports a change from main to a named release. label Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants