CoursewareSearch - Show filters if needed only #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1287 +/- ##
==========================================
+ Coverage 88.33% 88.35% +0.01%
==========================================
Files 291 291
Lines 4929 4936 +7
Branches 1242 1242
==========================================
+ Hits 4354 4361 +7
Misses 561 561
Partials 14 14 ☔ View full report in Codecov by Sentry. |
rijuma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: KBK-108 🔒
These changes hide the filter options with no results (no use). It also hides the filter entirely if the results consists of only one result type. In addition to this, I'm fixing some other minor issues that prevented the search results to show properly.
UI changes
Full results
all-result-types
Partial filters results
two-result-types
Only one result type (no need for filtering)
one-result-type-only
Removed double message on empty results (also improved the UI a bit)
no-results