Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for design tokens and CSS variables #1183

Closed
wants to merge 1 commit into from
Closed

feat: add support for design tokens and CSS variables #1183

wants to merge 1 commit into from

Conversation

xitij2000
Copy link
Contributor

No description provided.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Sep 12, 2023 •
edited
Loading

Thanks for the pull request, @xitij2000! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Sep 13, 2023
@itsjeyd
Copy link

itsjeyd commented Oct 10, 2023

@xitij2000 Just checking, this PR is still relevant, right?

@itsjeyd itsjeyd added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Oct 17, 2023
@itsjeyd
Copy link

itsjeyd commented Nov 17, 2023

@xitij2000 When you get a minute could you please post an update here about when you're planning to get back to this PR?

@xitij2000
Copy link
Contributor Author

@xitij2000 When you get a minute could you please post an update here about when you're planning to get back to this PR?

This and all the other PRs RE: design tokens are all based on an alpha version of paragon, so they are mainly for testing the MFE with design tokens. They can be updated when the version of paragon with design tokens is released, and potentially merged whent that happens.

@xitij2000 xitij2000 marked this pull request as draft November 17, 2023 13:25
@itsjeyd
Copy link

itsjeyd commented Nov 23, 2023

Thanks @xitij2000, I'll mark this PR as blocked on other work shortly.

@itsjeyd itsjeyd removed the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Nov 23, 2023
@itsjeyd
Copy link

itsjeyd commented Jan 12, 2024

@xitij2000 Just checking in:

This and all the other PRs RE: design tokens ... can be updated when the version of paragon with design tokens is released, ...

Do you have an update on when that might happen?

@xitij2000
Copy link
Contributor Author

@xitij2000 Just checking in:

This and all the other PRs RE: design tokens ... can be updated when the version of paragon with design tokens is released, ...

Do you have an update on when that might happen?

Not really. Since the budget for this epic is small I'll close this for now and come back to it when the foundations are closer to complete.

@xitij2000 xitij2000 closed this Jan 16, 2024
@openedx-webhooks
Copy link

@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks
Copy link

@xitij2000 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xitij2000 @openedx-webhooks @itsjeyd