Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use browserslist-config #523

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

arbrandes
Copy link
Contributor

@arbrandes arbrandes commented Dec 6, 2024

We were installing browserslist-config but not declaring it. This had the effect that webpack - and likely others - were not using it.

@arbrandes arbrandes requested a review from a team as a code owner December 6, 2024 13:22
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.40%. Comparing base (f9d13c4) to head (2ecea02).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   97.40%   97.40%           
=======================================
  Files         157      157           
  Lines        1389     1389           
  Branches      232      231    -1     
=======================================
  Hits         1353     1353           
  Misses         34       34           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We were installing browserslist-config but not declaring it.  This had
the effect that webpack - and likely others - were not using it.
Copy link
Contributor

@brian-smith-tcril brian-smith-tcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@arbrandes arbrandes merged commit 604298e into openedx:master Dec 6, 2024
6 checks passed
@arbrandes arbrandes deleted the fix-browserslist-config branch December 6, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants