Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge prod-ready JS configuration to 2u/main branch #306

Merged
merged 14 commits into from
Mar 29, 2024
Merged

Conversation

jsnwesson
Copy link
Contributor

@jsnwesson jsnwesson commented Mar 28, 2024

This PR adds a patch package for the frontend-build dependency to handle JS configs in production.

Note: I forgot to squash the commits before merging the JS config PR to master, hence the repeated files that are included in this PR. Will squash on merge.

@jsnwesson jsnwesson requested a review from a team as a code owner March 28, 2024 18:10
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.62%. Comparing base (5083645) to head (e045932).
Report is 2 commits behind head on 2u/main.

Files Patch % Lines
src/data/redux/hooks/app.js 84.61% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           2u/main     #306      +/-   ##
===========================================
- Coverage    96.69%   96.62%   -0.08%     
===========================================
  Files          183      182       -1     
  Lines         1725     1747      +22     
  Branches       308      308              
===========================================
+ Hits          1668     1688      +20     
- Misses          53       55       +2     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnwesson jsnwesson merged commit 3187df6 into 2u/main Mar 29, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants