Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragon StatusAlert deprecation #248

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

abdullahwaheed
Copy link
Contributor

Ticket

Migrate off deprecated Paragon components

What has changed

Removed deprecated StatusAlert component of paragon and updated it with Alert

References

Paragon StatusAlert
Paragon Alert

@abdullahwaheed abdullahwaheed requested a review from a team June 21, 2022 05:56
@abdullahwaheed abdullahwaheed requested a review from a team as a code owner June 21, 2022 05:56
@abdullahwaheed abdullahwaheed self-assigned this Jun 21, 2022
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #248 (8f28fab) into master (bf70fd1) will not change coverage.
The diff coverage is n/a.

❗ Current head 8f28fab differs from pull request most recent head 6e990e9. Consider uploading reports for the commit 6e990e9 to get more accurate results

@@            Coverage Diff            @@
##            master      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          110       110           
  Lines         1277      1277           
  Branches       251       251           
=========================================
  Hits          1277      1277           
Impacted Files Coverage Δ
src/components/GradesView/EditModal/index.jsx 100.00% <ø> (ø)
src/components/GradesView/StatusAlerts.jsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbb7e89...6e990e9. Read the comment docs.

Copy link
Contributor

@davidjoy davidjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change - the owning team should also review so they're aware of the change, it should be tested by Fed-BOM and we can get it in. I did a cursory review.

refactor: migrated StatusAlert to Alert in StatusAlerts component

refactor: updated unit tests mocks to set snapshot issues
@leangseu-edx leangseu-edx force-pushed the abdullah/paragon-status-alert-deprecation branch from 8f28fab to 6e990e9 Compare June 30, 2022 18:31
@leangseu-edx leangseu-edx merged commit a75f365 into master Jul 1, 2022
@leangseu-edx leangseu-edx deleted the abdullah/paragon-status-alert-deprecation branch July 1, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants