-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update paragon and frontend-build to openedx scope #818
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -56,8 +56,8 @@ describe('<PageAlerts />', () => { | |
}); | ||
|
||
it('renders null when no alerts are present', () => { | ||
const { container } = renderComponent(); | ||
expect(container).toBeEmptyDOMElement(); | ||
const { queryByTestId } = renderComponent(); | ||
expect(queryByTestId('browser-router')).toBeEmptyDOMElement(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As of openedx/frontend-platform#615, the <div data-testid="browser-router"> and the <div data-testid="redux-provider"> so instead of the whole container being an empty DOM element, it is <div data-testid="redux-provider"><div data-testid="browser-router"></div></div> This just updates the test to ensure nothing is rendered inside those divs that are always rendered |
||
}); | ||
|
||
it('renders configuration alerts', async () => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was on
2.3.0
due to thepackage-lock.json
, after rebuilding the package lock to cleanly handle the scope changes it updated to2.3.3
and caused https://github.com/openedx/frontend-app-course-authoring/actions/runs/7746261151/job/21124075247 to fail with errors such asPinning it to
2.3.0
prevents those errors.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections. We can deal with that later.