fix: await async saveSetting func to remove unwanted err msg

[navinkarkera]

Without this change, an error msg is displayed till the request runs, i.e. it is not waiting for the request to complete.

This issue was discovered while testing/reviewing openedx/frontend-app-learning#1194

[openedx-webhooks]

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (c47c800) 86.45% compared to head (bcef4e1) 86.45%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #610   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files         372      372           
  Lines        5580     5580           
  Branches     1235     1235           
=======================================
  Hits         4824     4824           
  Misses        732      732           
  Partials       24       24           

Files Changed	Coverage Δ
src/pages-and-resources/progress/Settings.jsx	0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[navinkarkera]

@brian-smith-tcril Could you please help us in reviewing and merging this?

[brian-smith-tcril]

This makes sense!

saveSetting is async
https://github.com/openedx/frontend-app-course-authoring/blob/97d0a1ce61c1b051b75c8aafe1465207340d9f85/src/utils.js#L122

handleSettingsSave is passed in to AppSettingsModal as onSettingsSave
https://github.com/openedx/frontend-app-course-authoring/blob/bcef4e1c27ad4830c480c7754a0d9232f5014dcd/src/pages-and-resources/progress/Settings.jsx#L29

AppSettingsModal expects onSettingsSave to be async
https://github.com/openedx/frontend-app-course-authoring/blob/97d0a1ce61c1b051b75c8aafe1465207340d9f85/src/pages-and-resources/app-settings-modal/AppSettingsModal.jsx#L148

LGTM!

[brian-smith-tcril]

I'm going to merge this despite the CodeCov patch coverage showing 0%. The overall change the the project is 0%, this fix is just touching code that didn't have coverage before. I believe it makes more sense to get this fix merged now than to wait until we add test coverage to a couple lines of code that were never covered before.

[openedx-webhooks]

@navinkarkera 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.