Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct redirect to taxonomies page #1547

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DmytroAlipov
Copy link
Contributor

Description

  1. Open studio -> course -> unit -> click on Manage tags (or click on Manage tags under the three-dots button for the component)
Знімок екрана 2024-12-06 о 16 49 24
  1. Click on "enable a taxonomy" link
Знімок екрана 2024-12-06 о 16 50 46
  1. Taxonomies page in studio opened inside tags drawer
Знімок екрана 2024-12-06 о 16 49 36

Expected Result:

User redirected to Taxonomies page in Studio - like when tags drawer is opened on Course outline page (which is based on Course authoring MFE) for Unit or Section, etc
Знімок екрана 2024-12-06 о 16 47 20

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner December 6, 2024 14:51
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 6, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @DmytroAlipov!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@DmytroAlipov DmytroAlipov force-pushed the fix-redirected-to-taxonomies-page branch from f1cf1e5 to e8bafce Compare December 6, 2024 15:10
@DmytroAlipov DmytroAlipov force-pushed the fix-redirected-to-taxonomies-page branch from e8bafce to 2e18c94 Compare December 6, 2024 15:30
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (a0f6f43) to head (2e18c94).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/content-tags-drawer/ContentTagsDrawer.tsx 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1547      +/-   ##
==========================================
- Coverage   92.93%   92.93%   -0.01%     
==========================================
  Files        1073     1073              
  Lines       21093    21098       +5     
  Branches     4546     4477      -69     
==========================================
+ Hits        19603    19607       +4     
- Misses       1418     1425       +7     
+ Partials       72       66       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

} else {
navigate('/taxonomies');
}
}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! We never really test without any taxonomies so hadn't encountered this.

The bug is probably a non-issue on master anymore, because everyone is expected to use the new unit page and the legacy page is now off by default. But it's likely an issue in Sumac.

I notice that this is currently using a <Button but that's incorrect for a link that triggers a navigation. This should really just be a <Link> component (from react-router-dom) and then I think you can simplify it to <Link to="/taxonomies" target="_top" className="..."> and get rid of all the javascript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

3 participants