-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct redirect to taxonomies page #1547
base: master
Are you sure you want to change the base?
fix: correct redirect to taxonomies page #1547
Conversation
Thanks for the pull request, @DmytroAlipov! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
f1cf1e5
to
e8bafce
Compare
e8bafce
to
2e18c94
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1547 +/- ##
==========================================
- Coverage 92.93% 92.93% -0.01%
==========================================
Files 1073 1073
Lines 21093 21098 +5
Branches 4546 4477 -69
==========================================
+ Hits 19603 19607 +4
- Misses 1418 1425 +7
+ Partials 72 66 -6 ☔ View full report in Codecov by Sentry. |
} else { | ||
navigate('/taxonomies'); | ||
} | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! We never really test without any taxonomies so hadn't encountered this.
The bug is probably a non-issue on master anymore, because everyone is expected to use the new unit page and the legacy page is now off by default. But it's likely an issue in Sumac.
I notice that this is currently using a <Button
but that's incorrect for a link that triggers a navigation. This should really just be a <Link>
component (from react-router-dom) and then I think you can simplify it to <Link to="/taxonomies" target="_top" className="...">
and get rid of all the javascript.
Description
Expected Result:
User redirected to Taxonomies page in Studio - like when tags drawer is opened on Course outline page (which is based on Course authoring MFE) for Unit or Section, etc