-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump frontend-build, remove exceptions for prefer-default-export #1519
chore: bump frontend-build, remove exceptions for prefer-default-export #1519
Conversation
Thanks for the pull request, @bradenmacdonald! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1519 +/- ##
=======================================
Coverage 93.04% 93.04%
=======================================
Files 1049 1051 +2
Lines 20582 20589 +7
Branches 4375 4445 +70
=======================================
+ Hits 19151 19158 +7
+ Misses 1361 1359 -2
- Partials 70 72 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@arbrandes Here we go :) Do you mind giving this a quick look and thumbs up? |
c0c5a5c
to
8c9a4d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Thanks for the clean-up, Braden!
Description
This PR bumps
frontend-build
to pull in the eslint config changes from openedx/eslint-config#164 so that default exports are no longer recommended in single-export files. This lets us remove a huge number of exceptions specified in the code, as you can see in the diff.Testing instructions
This should only affect linting; no changes to the behavior of the code. Run
npm run lint
or just check the CI output.