Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable problem bank button functionality [FC-0062] #1480

Merged
merged 4 commits into from
Nov 14, 2024
Merged

feat: enable problem bank button functionality [FC-0062] #1480

merged 4 commits into from
Nov 14, 2024

Conversation

navinkarkera
Copy link
Contributor

@navinkarkera navinkarkera commented Nov 7, 2024 •
edited
Loading

Description

Implements: #1462

Also, updates library v2 and problem bank icons and adds a beta tag based on api response.

Supporting information

Testing instructions

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 7, 2024 •
edited
Loading

Thanks for the pull request, @navinkarkera!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.01%. Comparing base (efd2b3d) to head (7e442ae).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1480   +/-   ##
=======================================
  Coverage   93.01%   93.01%           
=======================================
  Files        1048     1048           
  Lines       20485    20494    +9     
  Branches     4332     4336    +4     
=======================================
+ Hits        19054    19063    +9     
  Misses       1363     1363           
  Partials       68       68

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@navinkarkera navinkarkera force-pushed the navin/improve-lib-buttons branch 2 times, most recently from 72b503f to f8e00da Compare November 12, 2024 05:54
@navinkarkera navinkarkera mentioned this pull request Nov 12, 2024
Merged
rpenido
rpenido approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@rpenido rpenido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Thank you for your work, @navinkarkera!

  • I tested this using the instructions from the PR
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

src/course-unit/add-component/add-component-modals/ComponentModalView.jsx
Comment on lines +61 to +64
<div
key={componentTemplate.displayName}
className="d-flex justify-content-between w-100 mb-2.5 align-items-end"
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@navinkarkera navinkarkera marked this pull request as ready for review November 14, 2024 05:19
@navinkarkera navinkarkera requested a review from a team as a code owner November 14, 2024 05:19
@navinkarkera
feat: enable problem bank button functionality
af6a0ee 
Also, updates library v2 and problem bank icons and adds a beta tag
based on api response.
@navinkarkera
test: add tests
64d6f0b
@navinkarkera
test: improve coverage
3df8939
@navinkarkera
feat: add library v2 component in course (#75)
7e442ae 
* feat: add library v2 component in course

* test: add test for lib v2 component

* test: fix failing tests

* refactor: remove ComponentPickerModal component

Replace with standard modal and component picker components.
@navinkarkera navinkarkera force-pushed the navin/improve-lib-buttons branch from b6ee727 to 7e442ae Compare November 14, 2024 05:35
@navinkarkera
Copy link
Contributor Author

@ChrisChV Merged open-craft#75 here. This is ready for you.

@ChrisChV
Copy link
Contributor

@navinkarkera don't forget to add the [FC-0062] or the corresponding one in the title

@ChrisChV ChrisChV changed the title feat: enable problem bank button functionality feat: enable problem bank button functionality [FC-0062] Nov 14, 2024
@ChrisChV
Copy link
Contributor

Go to any unit page in any course and verify that Problem Bank option is working (adding a problem block). Verify the icons and beta badge for Problem Bank and Library content buttons.

@navinkarkera I don't see the beta badge on the buttons on the MFE unit page. Is it that expected?

image

@bradenmacdonald
Copy link
Contributor

@ChrisChV I am seeing it with this branch. You probably need to update edx-platform as mentioned in the description.

Screenshot

@bradenmacdonald
Copy link
Contributor

I found a related bug, but we can fix it separately: #1502

@bradenmacdonald bradenmacdonald merged commit cee8888 into openedx:master Nov 14, 2024
7 checks passed
@bradenmacdonald bradenmacdonald deleted the navin/improve-lib-buttons branch November 14, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisChV ChrisChV ChrisChV approved these changes

@rpenido rpenido rpenido approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@navinkarkera @openedx-webhooks @ChrisChV @bradenmacdonald @rpenido