fix: proptypes

openedx · Mar 2, 2024 · da9fd27 · da9fd27
1 parent a6e2771
commit da9fd27
Show file tree

Hide file tree

Showing 10 changed files with 42 additions and 21 deletions.
diff --git a/src/course-outline/card-header/CardHeader.jsx b/src/course-outline/card-header/CardHeader.jsx
@@ -218,12 +218,13 @@ CardHeader.defaultProps = {
   discussionEnabled: false,
   discussionsSettings: {},
   parentInfo: {},
+  cardId: '',
 };
 
 CardHeader.propTypes = {
   title: PropTypes.string.isRequired,
   status: PropTypes.string.isRequired,
-  cardId: PropTypes.string.isRequired,
+  cardId: PropTypes.string,
   hasChanges: PropTypes.bool.isRequired,
   onClickPublish: PropTypes.func.isRequired,
   onClickConfigure: PropTypes.func.isRequired,

diff --git a/src/course-outline/card-header/StatusBadge.jsx b/src/course-outline/card-header/StatusBadge.jsx
@@ -35,7 +35,7 @@ StatusBadge.defaultProps = {
 
 StatusBadge.propTypes = {
   text: PropTypes.string,
-  icon: PropTypes.string,
+  icon: PropTypes.func,
   iconClassName: PropTypes.string,
 };
 

diff --git a/src/course-outline/section-card/SectionCard.test.jsx b/src/course-outline/section-card/SectionCard.test.jsx
@@ -18,6 +18,7 @@ let store;
 const section = {
   id: '123',
   displayName: 'Section Name',
+  category: 'chapter',
   published: true,
   visibilityState: 'live',
   hasChanges: false,
@@ -38,17 +39,20 @@ const renderComponent = (props) => render(
     <IntlProvider locale="en">
       <SectionCard
         section={section}
-        index="1"
+        index={1}
         canMoveItem={jest.fn()}
         onOrderChange={jest.fn()}
         onOpenPublishModal={jest.fn()}
         onOpenHighlightsModal={jest.fn()}
         onOpenDeleteModal={jest.fn()}
+        onOpenConfigureModal={jest.fn()}
         savingStatus=""
         onEditSectionSubmit={onEditSectionSubmit}
         onDuplicateSubmit={jest.fn()}
         isSectionsExpanded
         onNewSubsectionSubmit={jest.fn()}
+        isSelfPaced={false}
+        isCustomRelativeDatesActive={false}
         {...props}
       >
         <span>children</span>

diff --git a/src/course-outline/subsection-card/SubsectionCard.test.jsx b/src/course-outline/subsection-card/SubsectionCard.test.jsx
@@ -37,6 +37,7 @@ const section = {
 const subsection = {
   id: '123',
   displayName: 'Subsection Name',
+  category: 'sequential',
   published: true,
   visibilityState: 'live',
   hasChanges: false,
@@ -47,6 +48,7 @@ const subsection = {
     duplicable: true,
   },
   isHeaderVisible: true,
+  releasedToStudents: true,
 };
 
 const onEditSubectionSubmit = jest.fn();
@@ -58,17 +60,22 @@ const renderComponent = (props, entry = '/') => render(
         <SubsectionCard
           section={section}
           subsection={subsection}
-          index="1"
-          canMoveItem={jest.fn()}
+          index={1}
+          isSelfPaced={false}
+          getPossibleMoves={jest.fn()}
           onOrderChange={jest.fn()}
           onOpenPublishModal={jest.fn()}
           onOpenHighlightsModal={jest.fn()}
           onOpenDeleteModal={jest.fn()}
+          onNewUnitSubmit={jest.fn()}
+          isCustomRelativeDatesActive={false}
           onEditClick={jest.fn()}
           savingStatus=""
           onEditSubmit={onEditSubectionSubmit}
           onDuplicateSubmit={jest.fn()}
           namePrefix="subsection"
+          onOpenConfigureModal={jest.fn()}
+          onPasteClick={jest.fn()}
           {...props}
         >
           <span>children</span>

diff --git a/src/course-outline/unit-card/UnitCard.test.jsx b/src/course-outline/unit-card/UnitCard.test.jsx
@@ -36,6 +36,7 @@ const subsection = {
 const unit = {
   id: '123',
   displayName: 'unit Name',
+  category: 'vertical',
   published: true,
   visibilityState: 'live',
   hasChanges: false,
@@ -55,15 +56,19 @@ const renderComponent = (props) => render(
         section={section}
         subsection={subsection}
         unit={unit}
-        index="1"
-        canMoveItem={jest.fn()}
+        index={1}
+        getPossibleMoves={jest.fn()}
         onOrderChange={jest.fn()}
         onOpenPublishModal={jest.fn()}
         onOpenDeleteModal={jest.fn()}
+        onOpenConfigureModal={jest.fn()}
+        onCopyToClipboardClick={jest.fn()}
         savingStatus=""
         onEditSubmit={jest.fn()}
         onDuplicateSubmit={jest.fn()}
         getTitleLink={(id) => `/some/${id}`}
+        isSelfPaced={false}
+        isCustomRelativeDatesActive={false}
         {...props}
       />
     </IntlProvider>,

diff --git a/src/course-outline/utils.jsx b/src/course-outline/utils.jsx
@@ -61,7 +61,7 @@ const getItemStatusBadgeContent = (status, messages, intl) => {
   case ITEM_BADGE_STATUS.publishedNotLive:
     return {
       badgeTitle: intl.formatMessage(messages.statusBadgePublishedNotLive),
-      badgeIcon: '',
+      badgeIcon: null,
     };
   case ITEM_BADGE_STATUS.staffOnly:
     return {
@@ -81,7 +81,7 @@ const getItemStatusBadgeContent = (status, messages, intl) => {
   default:
     return {
       badgeTitle: '',
-      badgeIcon: '',
+      badgeIcon: null,
     };
   }
 };

diff --git a/src/course-outline/xblock-status/GradingPolicyAlert.jsx b/src/course-outline/xblock-status/GradingPolicyAlert.jsx
@@ -37,12 +37,13 @@ const GradingPolicyAlert = ({
 GradingPolicyAlert.defaultProps = {
   graded: false,
   gradingType: '',
+  courseGraders: [],
 };
 
 GradingPolicyAlert.propTypes = {
   graded: PropTypes.bool,
   gradingType: PropTypes.string,
-  courseGraders: PropTypes.arrayOf(PropTypes.string.isRequired).isRequired,
+  courseGraders: PropTypes.arrayOf(PropTypes.string.isRequired),
 };
 
 export default GradingPolicyAlert;
diff --git a/src/course-outline/xblock-status/ReleaseStatus.jsx b/src/course-outline/xblock-status/ReleaseStatus.jsx
@@ -53,13 +53,15 @@ const ReleaseStatus = ({
 
 ReleaseStatus.defaultProps = {
   explanatoryMessage: '',
+  releaseDate: '',
+  releasedToStudents: false,
 };
 
 ReleaseStatus.propTypes = {
   isInstructorPaced: PropTypes.bool.isRequired,
   explanatoryMessage: PropTypes.string,
-  releaseDate: PropTypes.string.isRequired,
-  releasedToStudents: PropTypes.bool.isRequired,
+  releaseDate: PropTypes.string,
+  releasedToStudents: PropTypes.bool,
 };
 
 export default ReleaseStatus;
diff --git a/src/course-outline/xblock-status/StatusMessages.jsx b/src/course-outline/xblock-status/StatusMessages.jsx
@@ -68,6 +68,7 @@ StatusMessages.defaultProps = {
   prereq: '',
   prereqs: [],
   userPartitionInfo: {},
+  hasPartitionGroupComponents: false,
 };
 
 StatusMessages.propTypes = {
@@ -79,10 +80,10 @@ StatusMessages.propTypes = {
     blockDisplayName: PropTypes.string.isRequired,
   })),
   userPartitionInfo: PropTypes.shape({
-    selectedPartitionIndex: PropTypes.number.isRequired,
-    selectedGroupsLabel: PropTypes.string.isRequired,
+    selectedPartitionIndex: PropTypes.number,
+    selectedGroupsLabel: PropTypes.string,
   }),
-  hasPartitionGroupComponents: PropTypes.bool.isRequired,
+  hasPartitionGroupComponents: PropTypes.bool,
 };
 
 export default StatusMessages;
diff --git a/src/course-outline/xblock-status/XBlockStatus.jsx b/src/course-outline/xblock-status/XBlockStatus.jsx
@@ -93,8 +93,8 @@ XBlockStatus.propTypes = {
   blockData: PropTypes.shape({
     category: PropTypes.string.isRequired,
     explanatoryMessage: PropTypes.string,
-    releasedToStudents: PropTypes.bool.isRequired,
-    releaseDate: PropTypes.string.isRequired,
+    releasedToStudents: PropTypes.bool,
+    releaseDate: PropTypes.string,
     isProctoredExam: PropTypes.bool,
     isOnboardingExam: PropTypes.bool,
     isPracticeExam: PropTypes.bool,
@@ -105,16 +105,16 @@ XBlockStatus.propTypes = {
     })),
     staffOnlyMessage: PropTypes.bool,
     userPartitionInfo: PropTypes.shape({
-      selectedPartitionIndex: PropTypes.number.isRequired,
-      selectedGroupsLabel: PropTypes.string.isRequired,
+      selectedPartitionIndex: PropTypes.number,
+      selectedGroupsLabel: PropTypes.string,
     }),
-    hasPartitionGroupComponents: PropTypes.bool.isRequired,
+    hasPartitionGroupComponents: PropTypes.bool,
     format: PropTypes.string,
     dueDate: PropTypes.string,
     relativeWeeksDue: PropTypes.number,
     isTimeLimited: PropTypes.bool,
     graded: PropTypes.bool,
-    courseGraders: PropTypes.arrayOf(PropTypes.string.isRequired).isRequired,
+    courseGraders: PropTypes.arrayOf(PropTypes.string.isRequired),
     hideAfterDue: PropTypes.bool,
   }).isRequired,
 };