Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the "prefer-default-export" rule and "no-restricted-syntax" #164

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Disable the "prefer-default-export" rule and "no-restricted-syntax" #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d548c95
feat: Don't require default export for single-export modules
bradenmacdonald Oct 7, 2024
e9f470b
feat: Turn off the 'no-restricted-syntax' rule which isn't relevant
bradenmacdonald Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ module.exports = {
},
],
'arrow-parens': 'off',
// Avoiding default exports is recommended (https://dev.to/phuocng/avoid-using-default-exports-a1c)
// but we had 'prefer-default-export' on for a long time so we can't turn on 'no-default-export' without causing
// a large refactor.
'import/prefer-default-export': 'off',
// There is no reason to disallow this syntax anymore; we don't use regenerator-runtime in new browsers
'no-restricted-syntax': 'off',
'jsx-a11y/label-has-associated-control': ['error', {
labelComponents: [],
labelAttributes: [],
Expand Down