fix: remove unapplicable conditional unique constraint on subsidy #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENT-7891 | MySQL has never supported conditional unique constraints. This commit removes a conditional unique constraint declared in the subsidy model's Meta class. It also has a no-op migration for same. Lastly, adds a migration for historical subsidy records from upgraded django-simple-history.
iloveagent57
force-pushed
the
aed/subsidy-uniqueness
branch
from
ecfd36d to
6548ef3
Compare
macdiesel
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-7891 | MySQL has never supported conditional unique constraints. This commit removes a conditional unique constraint declared in the subsidy model's Meta class. It also has a no-op migration for same. Lastly, adds a migration for historical subsidy records from upgraded django-simple-history.
Description
Describe in a couple of sentences what this PR adds
Testing instructions
make db-shell-8to shell into mysql and runshow create table subsidy;. Note there is no unique constraint corresponding to what's stated in the model../manage.py migratein anapp-shellto run migrations.Merge checklist