feat: include restricted runs in algolia objects #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwnage101
force-pushed
the
pwnage101/ENT-9505
branch
4 times, most recently
from
9d40ef7 to
0d00393
Compare
pwnage101
commented
Oct 17, 2024
| @@ -1746,74 +1755,136 @@ def mock_replace_all_objects(products_iterable): | |||
| assert expected_call_args == self._sort_tags_in_algolia_object_list(actual_call_args) | |||
|
|
|||
| @mock.patch('enterprise_catalog.apps.api.tasks.get_initialized_algolia_client', return_value=mock.MagicMock()) | |||
| # pylint: disable=too-many-statements | |||
There was a problem hiding this comment.
github really fudged this diff view. If you look at the file directly I only added two tests:
- test_index_algolia_restricted_runs_mixed_course
- test_index_algolia_restricted_runs_unicorn_course
pwnage101
force-pushed
the
pwnage101/ENT-9505
branch
from
0d00393 to
bfa9099
Compare
iloveagent57
approved these changes
Oct 17, 2024
| # catalog queries that explicitly allow runs in those courses. We can tell that a course | ||
| # has only restricted runs simply by checking that it normally doesn't have an | ||
| # advertised run. | ||
| # pylint: disable=protected-access |
There was a problem hiding this comment.
nit: you could add an advertised_course_run_uuid() property to ContentMetadata to avoid this protected-access warning.
There was a problem hiding this comment.
Actually, I'm not sure that kind of getter design is sufficiently explicit when there's potentially two options: the values from _json_metadata vs. json_metadata, especially when I expect the value to differ depending on which is queried. My preference is to keep this as written and elaborate on the code comment.
pwnage101
force-pushed
the
pwnage101/ENT-9505
branch
from
bfa9099 to
feec4a4
Compare
pwnage101
force-pushed
the
pwnage101/ENT-9505
branch
from
feec4a4 to
b6bfbb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENT-9505
Important features: