Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aed/default enrollments bff #601

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Aed/default enrollments bff #601

merged 1 commit into from
Nov 26, 2024

Conversation

iloveagent57
Copy link
Contributor

Realizes default enrollment intentions.

Jira:
ENT-9632

Merge checklist:

  • ./manage.py makemigrations has been run
    • Note: This must be run if you modified any models.
      • It may or may not make a migration depending on exactly what you modified, but it should still be run.

Post merge:

  • Ensure that your changes went out to the stage instance
  • Deploy to prod instance

adamstankiewicz
adamstankiewicz reviewed Nov 25, 2024
View reviewed changes
enterprise_access/apps/bffs/handlers.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/handlers.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/mixins.py Outdated Show resolved Hide resolved
enterprise_access/apps/bffs/serializers.py
@@ -261,7 +263,7 @@ class EnterpriseCourseEnrollmentSerializer(BaseBffSerializer):
org_name = serializers.CharField()
course_run_status = serializers.CharField()
display_name = serializers.CharField()
emails_enabled = serializers.BooleanField()
emails_enabled = serializers.BooleanField(required=False, allow_null=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch that this is valid to be nullable! (source)

@iloveagent57 iloveagent57 force-pushed the aed/default-enrollments-bff branch 4 times, most recently from 33ab431 to ad9439e Compare November 25, 2024 21:07
adamstankiewicz
adamstankiewicz approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@adamstankiewicz adamstankiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just looks like the quality check is failing CI.

@iloveagent57 iloveagent57 force-pushed the aed/default-enrollments-bff branch from ad9439e to 76d54f5 Compare November 26, 2024 14:43
@iloveagent57 iloveagent57 force-pushed the aed/default-enrollments-bff branch from 76d54f5 to 72f7e09 Compare November 26, 2024 14:58
@iloveagent57 iloveagent57 merged commit 106b52b into main Nov 26, 2024
3 checks passed
@iloveagent57 iloveagent57 deleted the aed/default-enrollments-bff branch November 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamstankiewicz adamstankiewicz adamstankiewicz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iloveagent57 @adamstankiewicz