Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adds url negation regex for course id #36028

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

brobro10000
Copy link
Member

Description

This ticket adds a negation endpoints regex to strip from captured course_ids. Since some URLs being parsed do not contain a run, the existing regex in place captures additional URL strings that are not pertinent to a course_id.
This PR adds a negation regex to strip out endpoints that may appear in URLs where a run is not included as part of the course_id. The implementation of including a negation regex as opposed to modifying the original regex was an intentional decision to improve the extensibility of adding additional negation routes if need be.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

https://2u-internal.atlassian.net/browse/ENT-9770

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None"

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant