feat: reapply forum v2 changes #36002
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @regisb! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
regisb
force-pushed
the
regisb/forumv2
branch
2 times, most recently
from
4db17f3 to
5ad0f1f
Compare
|
EDIT: CI was not broken, it's just that I was compiling requirements with python 3.11.1, and I should have used 3.11.10. The issue comes from that line in redis-py: https://github.com/redis/redis-py/blob/8f2276e14d98b20cd9fc7b4a9e4e084fe9c74609/setup.py#L38 |
This reverts commit 818aa34.
We introduce a setting that allows us to bypass any course waffle flag check. The advantage of such a setting is that we don't need to find the course ID: in some cases, we might not have access to the course ID, and we need to look for it... in forum v2. See discussion here: openedx/forum#137
regisb
force-pushed
the
regisb/forumv2
branch
from
5ad0f1f to
5520613
Compare
|
Let's wait until we've merged openedx/forum#139 Then we can bump forum to 0.1.5 here. EDIT: done: https://pypi.org/project/openedx-forum/ This should be ready to merge. FYI @ormsbee |
This should fix an issue with index creation on edX.org.
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
* feat: Reapply "Integrate Forum V2 into edx-platform" This reverts commit 818aa34. * feat: make it possible to globally disable forum v2 with setting We introduce a setting that allows us to bypass any course waffle flag check. The advantage of such a setting is that we don't need to find the course ID: in some cases, we might not have access to the course ID, and we need to look for it... in forum v2. See discussion here: openedx/forum#137 * chore: bump openedx-forum to 0.1.5 This should fix an issue with index creation on edX.org.
Description
Restore the following PR: #35671
Include the following feature: #35995
Supporting information
See discussion here: openedx/forum#137 (comment)
FYI @ormsbee