Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix readthedocs build fail #35939

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Fix readthedocs build fail #35939

merged 2 commits into from
Dec 6, 2024

Conversation

irtazaakram
Copy link
Member

@irtazaakram irtazaakram mentioned this pull request Dec 2, 2024
Closed
feanil
feanil approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this helps build locally, but is still taking a long time on readthedocs. Perhaps we should disable all the autoapi_dirs for now to unblock other docs.

@irtazaakram irtazaakram requested a review from a team as a code owner December 5, 2024 06:52
@irtazaakram
Copy link
Member Author

I've disabled autoapi here be0f5cf.

@irtazaakram
Copy link
Member Author

https://docs.openedx.org/projects/edx-platform/en/fix-readthedocs/index.html

feanil
feanil approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can you

  • Backport this to the Sumac branch
  • Write up a ticket to investigate this further that we can pick up later.

@irtazaakram irtazaakram mentioned this pull request Dec 6, 2024
Open
@irtazaakram
Copy link
Member Author

I've created issue here #35977.

@irtazaakram irtazaakram mentioned this pull request Dec 6, 2024
Merged
@irtazaakram
Copy link
Member Author

sumac backport PR #35978

@feanil
Copy link
Contributor

feanil commented Dec 6, 2024

Looks great, feel free to merge this and the other PR whenever you're ready.

@irtazaakram irtazaakram merged commit 0dd9f8f into master Dec 6, 2024
49 checks passed
@irtazaakram irtazaakram deleted the fix-readthedocs branch December 6, 2024 13:58
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been rolled back from the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irtazaakram @feanil @edx-pipeline-bot