Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip positioning near edge [FC-0062] #35848

Merged

Conversation

rpenido
Copy link
Contributor

@rpenido rpenido commented Nov 14, 2024

Description

This PR fixes the tooltip positioning rule to avoid rendering it outside the window/iframe.

Before

image
image

After

image
image

Additional Infomation

Testing Instructions

  1. Open the Unit Outline in the course authoring MFE
  2. Open the browser console and edit the DOM adding a data-tooltip attribute to any element near the left edge of the screen like the example below:
    image
  3. Put the mouse over the element an check if it is rendered inside the screen/iframe limit
  4. Repeat the process with an element near the right edge

Private ref: FAL-3941

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 14, 2024

Thanks for the pull request, @rpenido!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@rpenido rpenido force-pushed the rpenido/fal-3941-fix-tooltip-positioning branch from bd5a05b to 900b527 Compare November 14, 2024 18:40
@rpenido rpenido marked this pull request as ready for review November 14, 2024 18:53
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for this fix @rpenido ! Works great.

  • I tested this using the PR test instructions and a Library Content block in the new Unit outline view.
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate -- wasn't able to see the tooltip using my keyboard only, but fixing this is outside the scope of this task.
  • Includes documentation
  • User-facing strings are extracted for translation

@rpenido rpenido changed the title fix: tooltip positioning near edge fix: tooltip positioning near edge [FC-0062] Nov 15, 2024
@rpenido rpenido force-pushed the rpenido/fal-3941-fix-tooltip-positioning branch from 900b527 to d82cecc Compare November 15, 2024 14:12
@ChrisChV ChrisChV enabled auto-merge (squash) November 15, 2024 18:11
@ChrisChV ChrisChV merged commit 842aec4 into openedx:master Nov 15, 2024
50 checks passed
@ChrisChV ChrisChV deleted the rpenido/fal-3941-fix-tooltip-positioning branch November 15, 2024 18:38
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants