Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [FC-0070] add message events to the unit page container #35693

Merged

Conversation

ihor-romaniuk
Copy link
Contributor

@ihor-romaniuk ihor-romaniuk commented Oct 22, 2024

🚨 Dependencies:

Description

This feature introduces two main functionalities to improve XBlock interactions within iframes:

  • Add an event listener to the window object that listens for messages of type refreshXBlock. Upon receiving such a message, the render() method is called to refresh the current XBlock.
  • When the isIframeEmbed option is enabled, the XBlock sends a postMessage to the parent window. This message contains information about the source XBlock and its parent, triggering a modal display in the parent context.
move-xblock.mov

Related Pull Requests

Testing instructions

  • сreate a new course.
  • create several units.
  • open the course unit page.
  • add some xBlocks to the unit.
  • move xBlock to another unit: click three dots icon (xBlock action menu) -> select "Move" -> select new location.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 22, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 22, 2024

Thanks for the pull request, @ihor-romaniuk!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/implement-move-xblock-modal branch from 661ecde to d9c49cb Compare November 11, 2024 14:32
@ihor-romaniuk ihor-romaniuk force-pushed the romaniuk/implement-move-xblock-modal branch from d9c49cb to 6f65bcf Compare November 15, 2024 07:48
Copy link

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and it works when used in conjunction with openedx/frontend-app-authoring#1422.

@arbrandes arbrandes merged commit a34a54d into openedx:master Nov 18, 2024
51 checks passed
@ihor-romaniuk ihor-romaniuk deleted the romaniuk/implement-move-xblock-modal branch November 18, 2024 16:24
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@ihor-romaniuk ihor-romaniuk restored the romaniuk/implement-move-xblock-modal branch November 19, 2024 07:49
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@ihor-romaniuk ihor-romaniuk deleted the romaniuk/implement-move-xblock-modal branch November 22, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FC Relates to an Axim Funded Contribution project open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants