-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove duplicate (unclosed) tag #35682
base: master
Are you sure you want to change the base?
Conversation
## Description This PR removes some bad (duplicated) markup in the static tab file. The current behavior leads to an unclosed HTML tag, which can be confirmed by viewing the document source. --- See original, abandoned PR here: openedx#35301 See a 2nd abandoned PR here: openedx#35382
Thanks for the pull request, @rediris! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@mphilbrick211 I can review this one once the CLA check is green. |
Hi @rediris! Just checking in to see if you need anything regarding your CLA? I'm not sure if your manager has reached out to us yet. |
Hi @mphilbrick211, |
Hi @mphilbrick211 @kdmccormick, the individual CLA should be all set. Hopefully the folks at axim can confirm this and we can finally get this one merged! |
Hi @rediris! Flagging that an additional test has popped up that needs to be run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just merged in master--that should do the trick. I'll merge this as soon as tests pass.
Hi @kdmccormick is there any action needed on my part at this time? |
I'll take it from here. Thanks Roman. |
Description
This PR removes some bad (duplicated) markup in the static tab file. The current behavior leads to an unclosed HTML tag, which can be confirmed by viewing the document source.
See original, abandoned PR here: #35301
See a 2nd abandoned PR here: #35382
@kdmccormick