Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplicate (unclosed) tag #35682

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rediris
Copy link

@rediris rediris commented Oct 21, 2024

Description

This PR removes some bad (duplicated) markup in the static tab file. The current behavior leads to an unclosed HTML tag, which can be confirmed by viewing the document source.


See original, abandoned PR here: #35301

See a 2nd abandoned PR here: #35382

@kdmccormick

## Description

This PR removes some bad (duplicated) markup in the static tab file. The current behavior leads to an unclosed HTML tag, which can be confirmed by viewing the document source.

---
See original, abandoned PR here: openedx#35301

See a 2nd abandoned PR here:
openedx#35382
@openedx-webhooks
Copy link

openedx-webhooks commented Oct 21, 2024

Thanks for the pull request, @rediris!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 21, 2024
@kdmccormick
Copy link
Member

@mphilbrick211 I can review this one once the CLA check is green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 21, 2024
@mphilbrick211
Copy link

Hi @rediris!

Just checking in to see if you need anything regarding your CLA? I'm not sure if your manager has reached out to us yet.

@rediris
Copy link
Author

rediris commented Oct 21, 2024

Hi @rediris!

Just checking in to see if you need anything regarding your CLA? I'm not sure if your manager has reached out to us yet.

Hi @mphilbrick211,
In an effort to expedite the process, what I'm hoping to accomplish with this PR from my user profile rather than one from the Gymnasium org profile is to fill out a personal CLA. Can someone send my email a docusign to accomplish that? Meanwhile, I'll check in with our org's legal team to understand why no one has responded to my inquiry regarding the organizational CLA.

@rediris
Copy link
Author

rediris commented Oct 30, 2024

Hi @rediris!
Just checking in to see if you need anything regarding your CLA? I'm not sure if your manager has reached out to us yet.

Hi @mphilbrick211, In an effort to expedite the process, what I'm hoping to accomplish with this PR from my user profile rather than one from the Gymnasium org profile is to fill out a personal CLA. Can someone send my email a docusign to accomplish that? Meanwhile, I'll check in with our org's legal team to understand why no one has responded to my inquiry regarding the organizational CLA.

Hi @mphilbrick211 @kdmccormick, the individual CLA should be all set. Hopefully the folks at axim can confirm this and we can finally get this one merged!

@mphilbrick211 mphilbrick211 added needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Nov 4, 2024
@mphilbrick211
Copy link

Hi @rediris! Flagging that an additional test has popped up that needs to be run.

@mphilbrick211 mphilbrick211 removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Dec 9, 2024
Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just merged in master--that should do the trick. I'll merge this as soon as tests pass.

@kdmccormick kdmccormick enabled auto-merge (squash) December 10, 2024 13:49
@rediris
Copy link
Author

rediris commented Dec 10, 2024

I just merged in master--that should do the trick. I'll merge this as soon as tests pass.

Hi @kdmccormick is there any action needed on my part at this time?

@kdmccormick
Copy link
Member

I'll take it from here. Thanks Roman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

4 participants