-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: in-context discussion for units can be disabled by default #35414
feat: in-context discussion for units can be disabled by default #35414
Conversation
Thanks for the pull request, @kaustavb12! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good! I only wonder if this should be in FEATURES or just settings?
Hi @kaustavb12! Are you still planning to pursue this pull request? |
Hey @mphilbrick211 Yes, I would like to pursue this PR. |
@kaustavb12 can you please rebase the PR? |
36ee42c
to
2570aea
Compare
2570aea
to
83c9216
Compare
@farhaanbukhsh The PR has been rebased, please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this on Tutor devstack and this works perfectly, this work is under a feature flag so it should be okay to merge.
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
- ❌ I made sure any change in configuration variables is reflected in the corresponding client's
configuration-secure
repository.
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
Description
Currently for all new units which are added to a course, the in-context discussions is enabled by default, which the course instructor can disable individually.
This PR, adds to the ability to keep the in-context discussions disabled by default. That way all new units which are added will have the discussions sidebar disabled and can be individually enabled by the course instructors.
Testing instructions
IN_CONTEXT_DISCUSSION_ENABLED_DEFAULT
feature flag to FalseDeadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Private Ref : BB-9112