-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: course progress url based on whether the user has learning MFE enabled (for Redwood) #35149
fix: course progress url based on whether the user has learning MFE enabled (for Redwood) #35149
Conversation
Thanks for the pull request, @FatemeKhodayari! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Hi @FatemeKhodayari! Just flagging there's a failing check here. |
Hi @mphilbrick211. Based on the logs, guess the error is not on my side. Seems like a connection error on one of the API admin tests has caused the failure.
Please let me know if I'm wrong and anything needs changing. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this in my local redwood environment and it's working as expected. Here's how I tested it for future references:
- Configure a course for (verified) certificate generation
- As a student, enroll in the course
- Complete the course with a not-passing grade
- Archive the course
- Go to the learner dashboard page
- Inspect "view grades"
I'll be merging this now. Thank you!
1e0d575
into
openedx:open-release/redwood.master
@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Currently, as we have in Redwood, when a user hasn't passed the course, the "View Grades" link / button is displayed to him on the dashboard. Clicking on this link / button, takes the user to the old progress page. The URL of the old progress page is returned in the
/api/learner_home/init
response. In this change, course progress URL is returned based on whether the user has learning MFE enabled or not.This issue was originally created in this forum topic and later discussed a little bit in the Maintenance WG meeting.
Closes #34323