Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: course progress url based on whether the user has learning MFE enabled (for Redwood) #35149

Conversation

FatemeKhodayari
Copy link
Contributor

Currently, as we have in Redwood, when a user hasn't passed the course, the "View Grades" link / button is displayed to him on the dashboard. Clicking on this link / button, takes the user to the old progress page. The URL of the old progress page is returned in the /api/learner_home/init response. In this change, course progress URL is returned based on whether the user has learning MFE enabled or not.

This issue was originally created in this forum topic and later discussed a little bit in the Maintenance WG meeting.

Closes #34323

@FatemeKhodayari FatemeKhodayari requested a review from a team as a code owner July 22, 2024 12:26
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 22, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @FatemeKhodayari!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@FatemeKhodayari FatemeKhodayari changed the title fix: course progress url returned based on course_home_mfe_progress_t… fix: course progress url based on whether the user has learning MFE enabled (for Redwood) Jul 22, 2024
@deborahgu deborahgu added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Jul 22, 2024
@mphilbrick211
Copy link

Hi @FatemeKhodayari! Just flagging there's a failing check here.

@FatemeKhodayari
Copy link
Contributor Author

FatemeKhodayari commented Jul 25, 2024

Hi @mphilbrick211. Based on the logs, guess the error is not on my side. Seems like a connection error on one of the API admin tests has caused the failure.

FAILED
openedx/core/djangoapps/api_admin/tests/test_views.py::CatalogEditViewTest::test_delete - requests.exceptions.ConnectionError: ('Connection aborted.', gaierror(-2, 'Name or service not known'))

Please let me know if I'm wrong and anything needs changing. Thanks.

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in my local redwood environment and it's working as expected. Here's how I tested it for future references:

  1. Configure a course for (verified) certificate generation
  2. As a student, enroll in the course
  3. Complete the course with a not-passing grade
  4. Archive the course
  5. Go to the learner dashboard page
  6. Inspect "view grades"

I'll be merging this now. Thank you!

@mariajgrimaldi mariajgrimaldi merged commit 1e0d575 into openedx:open-release/redwood.master Jul 30, 2024
78 checks passed
@openedx-webhooks
Copy link

@FatemeKhodayari 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants