Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #34857

Merged
merged 7 commits into from
Jun 4, 2024
Merged

chore: cleanup #34857

merged 7 commits into from
Jun 4, 2024

Conversation

CodeWithEmad
Copy link
Member

I was reading some docs and noticed a lot of typos and styling issues. Nothing was changed logic-wise.

- rst heading definitions
- indirect hyperlinks and code-blocks for better readability
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 25, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@CodeWithEmad CodeWithEmad requested a review from feanil May 25, 2024 15:01
@feanil
Copy link
Contributor

feanil commented Jun 3, 2024

@CodeWithEmad we've had some major updates to the github workflows that you'll have to rebase on top of. Can you do that and I'll continue to review.

- rst heading definitions
- indirect hyperlinks and code-blocks added for better readability
- MarkDown warnings resolved
- Yaml style issues fixed
@CodeWithEmad
Copy link
Member Author

All resolved, @feanil

@feanil feanil merged commit 6b0789a into openedx:master Jun 4, 2024
45 checks passed
@openedx-webhooks
Copy link

@CodeWithEmad 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@CodeWithEmad CodeWithEmad deleted the chore/cleanup branch June 4, 2024 14:04
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants