Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include units when calculating completion percentage (#34816) #34856

Conversation

GlugovGrGlib
Copy link
Member

@GlugovGrGlib GlugovGrGlib commented May 24, 2024

Description

This is a redwood backport PR for the - #34816

This is an enhancement to the API used for the courseware navigation sidebar. This PR adds the calculation of user progress to the API for navigating the sidebar that returns the course structure.

Also, additional completion data being added to the backend response to address a bug that was uncovered during the release candidate testing process.

Testing instructions

  • Create a course with different access rights to course blocks (sections/subsections/subsections) for different users.
  • Make GET requests to the API (/api/course_home/v1/navigation/{course_id}) and check if the API returns the correct progress(completion_stat field) on the compliments for the user.
  • Get new completions in a test course
  • Make GET requests to the API again and check that the progress has changed.

Supporting information

This feature is done as part of FC-0056. Related GH issue: openedx/platform-roadmap#329

Deadline

June 2024 / Redwood release

…4816)

This is an enhancement to the API used for the courseware navigation
sidebar.
@openedx-webhooks
Copy link

Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 24, 2024
@GlugovGrGlib GlugovGrGlib requested a review from ormsbee May 24, 2024 21:30
@ormsbee ormsbee merged commit 9bc0f85 into openedx:open-release/redwood.master May 30, 2024
78 checks passed
@openedx-webhooks
Copy link

@GlugovGrGlib 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants